Commit b05c73bd authored by Maksim Salau's avatar Maksim Salau Committed by Marc Kleine-Budde
Browse files

net: can: usb: gs_usb: Fix buffer on stack 



Allocate buffers on HEAP instead of STACK for local structures
that are to be sent using usb_control_msg().

Signed-off-by: default avatarMaksim Salau <maksim.salau@gmail.com>
Cc: linux-stable <stable@vger.kernel.org> # >= v4.8
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 71b61156

drivers/net/can/usb/gs_usb.c

+12 −5
Original line number Diff line number Diff line
@@ -739,13 +739,18 @@ static const struct net_device_ops gs_usb_netdev_ops = { 
static int gs_usb_set_identify(struct net_device *netdev, bool do_identify)

{

	struct gs_can *dev = netdev_priv(netdev);

	struct gs_identify_mode imode;

	struct gs_identify_mode *imode;

	int rc;



	imode = kmalloc(sizeof(*imode), GFP_KERNEL);



	if (!imode)

		return -ENOMEM;



	if (do_identify)

		imode.mode = GS_CAN_IDENTIFY_ON;

		imode->mode = GS_CAN_IDENTIFY_ON;

	else

		imode.mode = GS_CAN_IDENTIFY_OFF;

		imode->mode = GS_CAN_IDENTIFY_OFF;



	rc = usb_control_msg(interface_to_usbdev(dev->iface),

			     usb_sndctrlpipe(interface_to_usbdev(dev->iface),
@@ -755,10 +760,12 @@ static int gs_usb_set_identify(struct net_device *netdev, bool do_identify) 
			     USB_RECIP_INTERFACE,

			     dev->channel,

			     0,

			     &imode,

			     sizeof(imode),

			     imode,

			     sizeof(*imode),

			     100);



	kfree(imode);



	return (rc > 0) ? 0 : rc;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE