Commit b04e6373 authored Aug 21, 2009 by Linus Torvalds

x86: don't call '->send_IPI_mask()' with an empty mask

As noted in 83d349f3 ("x86: don't send
an IPI to the empty set of CPU's"), some APIC's will be very unhappy
with an empty destination mask.  That commit added a WARN_ON() for that
case, and avoided the resulting problem, but didn't fix the underlying
reason for why those empty mask cases happened.

This fixes that, by checking the result of 'cpumask_andnot()' of the
current CPU actually has any other CPU's left in the set of CPU's to be
sent a TLB flush, and not calling down to the IPI code if the mask is
empty.

The reason this started happening at all is that we started passing just
the CPU mask pointers around in commit 4595f962 ("x86: change
flush_tlb_others to take a const struct cpumask"), and when we did that,
the cpumask was no longer thread-local.

Before that commit, flush_tlb_mm() used to create it's own copy of
'mm->cpu_vm_mask' and pass that copy down to the low-level flush
routines after having tested that it was not empty.  But after changing
it to just pass down the CPU mask pointer, the lower level TLB flush
routines would now get a pointer to that 'mm->cpu_vm_mask', and that
could still change - and become empty - after the test due to other
CPU's having flushed their own TLB's.

See

	http://bugzilla.kernel.org/show_bug.cgi?id=13933



for details.

Tested-by: Thomas Björnell <thomas.bjornell@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f4b0373b

arch/x86/mm/tlb.c

+10 −11

Original line number	Original line	Diff line number	Diff line
	@@ -183,9 +183,7 @@ static void flush_tlb_others_ipi(const struct cpumask *cpumask,

	f->flush_mm = mm;		f->flush_mm = mm;
	f->flush_va = va;		f->flush_va = va;
	cpumask_andnot(to_cpumask(f->flush_cpumask),		if (cpumask_andnot(to_cpumask(f->flush_cpumask), cpumask, cpumask_of(smp_processor_id()))) {
	cpumask, cpumask_of(smp_processor_id()));

	/*		/*
	* We have to send the IPI only to		* We have to send the IPI only to
	* CPUs affected.		* CPUs affected.
	@@ -195,6 +193,7 @@ static void flush_tlb_others_ipi(const struct cpumask *cpumask,

	while (!cpumask_empty(to_cpumask(f->flush_cpumask)))		while (!cpumask_empty(to_cpumask(f->flush_cpumask)))
	cpu_relax();		cpu_relax();
			}

	f->flush_mm = NULL;		f->flush_mm = NULL;
	f->flush_va = 0;		f->flush_va = 0;

Admin message