Commit b0407d82 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Guenter Roeck
Browse files

hwmon: (occ) Fix potential integer overflow 



Cast get_unaligned_be32(...) to u64 in order to give the compiler
complete information about the proper arithmetic to use and avoid
a potential integer overflow.

Notice that such function call is used in contexts that expect
expressions of type u64 (64 bits, unsigned); and the following
expressions are currently being evaluated using 32-bit
arithmetic:

val = get_unaligned_be32(&power->update_tag) *
                        occ->powr_sample_time_us;

val = get_unaligned_be32(&power->vdn.update_tag) *
                        occ->powr_sample_time_us;

Addresses-Coverity-ID: 1442357 ("Unintentional integer overflow")
Addresses-Coverity-ID: 1442476 ("Unintentional integer overflow")
Addresses-Coverity-ID: 1442508 ("Unintentional integer overflow")
Fixes: ff692d80b2e2 ("hwmon (occ): Add sensor types and versions")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: default avatarEddie James <eajames@linux.ibm.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 07bd14cc

drivers/hwmon/occ/common.c

+12 −12
Original line number Diff line number Diff line
@@ -380,7 +380,7 @@ static ssize_t occ_show_power_1(struct device *dev, 
		val *= 1000000ULL;

		break;

	case 2:

		val = get_unaligned_be32(&power->update_tag) *

		val = (u64)get_unaligned_be32(&power->update_tag) *

			   occ->powr_sample_time_us;

		break;

	case 3:
@@ -425,7 +425,7 @@ static ssize_t occ_show_power_2(struct device *dev, 
				       &power->update_tag);

		break;

	case 2:

		val = get_unaligned_be32(&power->update_tag) *

		val = (u64)get_unaligned_be32(&power->update_tag) *

			   occ->powr_sample_time_us;

		break;

	case 3:
@@ -463,7 +463,7 @@ static ssize_t occ_show_power_a0(struct device *dev, 
				       &power->system.update_tag);

		break;

	case 2:

		val = get_unaligned_be32(&power->system.update_tag) *

		val = (u64)get_unaligned_be32(&power->system.update_tag) *

			   occ->powr_sample_time_us;

		break;

	case 3:
@@ -477,7 +477,7 @@ static ssize_t occ_show_power_a0(struct device *dev, 
				       &power->proc.update_tag);

		break;

	case 6:

		val = get_unaligned_be32(&power->proc.update_tag) *

		val = (u64)get_unaligned_be32(&power->proc.update_tag) *

			   occ->powr_sample_time_us;

		break;

	case 7:
@@ -491,7 +491,7 @@ static ssize_t occ_show_power_a0(struct device *dev, 
				       &power->vdd.update_tag);

		break;

	case 10:

		val = get_unaligned_be32(&power->vdd.update_tag) *

		val = (u64)get_unaligned_be32(&power->vdd.update_tag) *

			   occ->powr_sample_time_us;

		break;

	case 11:
@@ -505,7 +505,7 @@ static ssize_t occ_show_power_a0(struct device *dev, 
				       &power->vdn.update_tag);

		break;

	case 14:

		val = get_unaligned_be32(&power->vdn.update_tag) *

		val = (u64)get_unaligned_be32(&power->vdn.update_tag) *

			   occ->powr_sample_time_us;

		break;

	case 15:

CRA Git | Maintained and supported by SUSTech CRA and CCSE