Unverified Commit b03c29c1 authored Jan 15, 2020 by Wei Yongjun Committed by Mark Brown Jan 17, 2020

ASoC: rt711: fix return value check in rt711_sdw_probe()



In case of error, the function devm_regmap_init() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: 320b8b0d ("ASoC: rt711: add rt711 codec driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200115143034.94492-1-weiyongjun1@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 20435df1

sound/soc/codecs/rt711-sdw.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -460,8 +460,8 @@ static int rt711_sdw_probe(struct sdw_slave *slave,

		regmap = devm_regmap_init(&slave->dev, NULL,
		&slave->dev, &rt711_regmap);
		if (!regmap)
		return -EINVAL;
		if (IS_ERR(regmap))
		return PTR_ERR(regmap);

		rt711_init(&slave->dev, sdw_regmap, regmap, slave);

Admin message