Commit b0353540 authored Aug 05, 2020 by Dan Carpenter Committed by Oded Gabbay Aug 22, 2020

habanalabs: Fix a loop in gaudi_extract_ecc_info()



The condition was reversed.  It should have been less than instead of
greater than.  The result is that we never enter the loop.

Fixes: fcc6a4e6 ("habanalabs: Extract ECC information from FW")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>

parent eeec23cd

drivers/misc/habanalabs/gaudi/gaudi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5250,7 +5250,7 @@ static int gaudi_extract_ecc_info(struct hl_device *hdev,
		*memory_wrapper_idx = 0xFF;

		/* Iterate through memory wrappers, a single bit must be set */
		for (i = 0 ; i > num_mem_regs ; i++) {
		for (i = 0 ; i < num_mem_regs ; i++) {
		err_addr += i * 4;
		err_word = RREG32(err_addr);
		if (err_word) {

Admin message