Commit b02c2b0b authored by Christoph Hellwig's avatar Christoph Hellwig
Browse files

sparc: remove arch specific dma_supported implementations 



Usually dma_supported decisions are done by the dma_map_ops instance.
Switch sparc to that model by providing a ->dma_supported instance for
sbus that always returns false, and implementations tailored to the sun4u
and sun4v cases for sparc64, and leave it unimplemented for PCI on
sparc32, which means always supported.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c6d333e0

arch/sparc/include/asm/dma-mapping.h

+0 −3
Original line number Diff line number Diff line
@@ -5,9 +5,6 @@ 
#include <linux/mm.h>

#include <linux/dma-debug.h>



#define HAVE_ARCH_DMA_SUPPORTED 1

int dma_supported(struct device *dev, u64 mask);



static inline void dma_cache_sync(struct device *dev, void *vaddr, size_t size,

				  enum dma_data_direction dir)

{

arch/sparc/kernel/iommu.c

+16 −24
Original line number Diff line number Diff line
@@ -746,6 +746,21 @@ static int dma_4u_mapping_error(struct device *dev, dma_addr_t dma_addr) 
	return dma_addr == SPARC_MAPPING_ERROR;

}



static int dma_4u_supported(struct device *dev, u64 device_mask)

{

	struct iommu *iommu = dev->archdata.iommu;



	if (device_mask > DMA_BIT_MASK(32))

		return 0;

	if ((device_mask & iommu->dma_addr_mask) == iommu->dma_addr_mask)

		return 1;

#ifdef CONFIG_PCI

	if (dev_is_pci(dev))

		return pci64_dma_supported(to_pci_dev(dev), device_mask);

#endif

	return 0;

}



static const struct dma_map_ops sun4u_dma_ops = {

	.alloc			= dma_4u_alloc_coherent,

	.free			= dma_4u_free_coherent,
@@ -755,32 +770,9 @@ static const struct dma_map_ops sun4u_dma_ops = { 
	.unmap_sg		= dma_4u_unmap_sg,

	.sync_single_for_cpu	= dma_4u_sync_single_for_cpu,

	.sync_sg_for_cpu	= dma_4u_sync_sg_for_cpu,

	.dma_supported		= dma_4u_supported,

	.mapping_error		= dma_4u_mapping_error,

};



const struct dma_map_ops *dma_ops = &sun4u_dma_ops;

EXPORT_SYMBOL(dma_ops);
 


int dma_supported(struct device *dev, u64 device_mask)

{

	struct iommu *iommu = dev->archdata.iommu;

	u64 dma_addr_mask = iommu->dma_addr_mask;



	if (device_mask > DMA_BIT_MASK(32)) {

		if (iommu->atu)

			dma_addr_mask = iommu->atu->dma_addr_mask;

		else

			return 0;

	}



	if ((device_mask & dma_addr_mask) == dma_addr_mask)

		return 1;



#ifdef CONFIG_PCI

	if (dev_is_pci(dev))

		return pci64_dma_supported(to_pci_dev(dev), device_mask);

#endif



	return 0;

}

EXPORT_SYMBOL(dma_supported);

arch/sparc/kernel/ioport.c

+6 −16
Original line number Diff line number Diff line
@@ -401,6 +401,11 @@ static void sbus_sync_sg_for_device(struct device *dev, struct scatterlist *sg, 
	BUG();

}



static int sbus_dma_supported(struct device *dev, u64 mask)

{

	return 0;

}



static const struct dma_map_ops sbus_dma_ops = {

	.alloc			= sbus_alloc_coherent,

	.free			= sbus_free_coherent,
@@ -410,6 +415,7 @@ static const struct dma_map_ops sbus_dma_ops = { 
	.unmap_sg		= sbus_unmap_sg,

	.sync_sg_for_cpu	= sbus_sync_sg_for_cpu,

	.sync_sg_for_device	= sbus_sync_sg_for_device,

	.dma_supported		= sbus_dma_supported,

};



static int __init sparc_register_ioport(void)
@@ -655,22 +661,6 @@ EXPORT_SYMBOL(pci32_dma_ops); 
const struct dma_map_ops *dma_ops = &sbus_dma_ops;

EXPORT_SYMBOL(dma_ops);





/*

 * Return whether the given PCI device DMA address mask can be

 * supported properly.  For example, if your device can only drive the

 * low 24-bits during PCI bus mastering, then you would pass

 * 0x00ffffff as the mask to this function.

 */

int dma_supported(struct device *dev, u64 mask)

{

	if (dev_is_pci(dev))

		return 1;



	return 0;

}

EXPORT_SYMBOL(dma_supported);



#ifdef CONFIG_PROC_FS



static int sparc_io_proc_show(struct seq_file *m, void *v)

arch/sparc/kernel/pci_sun4v.c

+17 −0
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 


#include "pci_impl.h"

#include "iommu_common.h"

#include "kernel.h"



#include "pci_sun4v.h"
@@ -669,6 +670,21 @@ static void dma_4v_unmap_sg(struct device *dev, struct scatterlist *sglist, 
	local_irq_restore(flags);

}



static int dma_4v_supported(struct device *dev, u64 device_mask)

{

	struct iommu *iommu = dev->archdata.iommu;

	u64 dma_addr_mask;



	if (device_mask > DMA_BIT_MASK(32) && iommu->atu)

		dma_addr_mask = iommu->atu->dma_addr_mask;

	else

		dma_addr_mask = iommu->dma_addr_mask;



	if ((device_mask & dma_addr_mask) == dma_addr_mask)

		return 1;

	return pci64_dma_supported(to_pci_dev(dev), device_mask);

}



static int dma_4v_mapping_error(struct device *dev, dma_addr_t dma_addr)

{

	return dma_addr == SPARC_MAPPING_ERROR;
@@ -681,6 +697,7 @@ static const struct dma_map_ops sun4v_dma_ops = { 
	.unmap_page			= dma_4v_unmap_page,

	.map_sg				= dma_4v_map_sg,

	.unmap_sg			= dma_4v_unmap_sg,

	.dma_supported			= dma_4v_supported,

	.mapping_error			= dma_4v_mapping_error,

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE