Commit b0270550 authored Apr 22, 2019 by Eric Dumazet Committed by David S. Miller Apr 23, 2019

ipv6: fib6_info_destroy_rcu() cleanup



We do not need to clear f6i->rt6i_exception_bucket right before
freeing f6i.

Note that f6i->rt6i_exception_bucket is properly protected by
f6i->exception_bucket_flushed being set to one in rt6_flush_exceptions()
under the protection of rt6_exception_lock.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Wei Wang <weiwan@google.com>
Acked-by: Wei Wang <weiwan@google.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 20eb08b2

net/ipv6/ip6_fib.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -175,10 +175,7 @@ void fib6_info_destroy_rcu(struct rcu_head *head)
		WARN_ON(f6i->fib6_node);

		bucket = rcu_dereference_protected(f6i->rt6i_exception_bucket, 1);
		if (bucket) {
		f6i->rt6i_exception_bucket = NULL;
		kfree(bucket);
		}

		if (f6i->rt6i_pcpu) {
		int cpu;

Admin message