Commit b01dd025 authored by Edward O'Callaghan's avatar Edward O'Callaghan Committed by Alex Deucher
Browse files

amdgpu: Use dev_err() over vanilla printk() in vm_decode_fault() 



Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarEdward O'Callaghan <funfunctor@folklore1984.net>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b00861b9

drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -711,7 +711,7 @@ static void gmc_v7_0_vm_decode_fault(struct amdgpu_device *adev, 
	mc_id = REG_GET_FIELD(status, VM_CONTEXT1_PROTECTION_FAULT_STATUS,

	mc_id = REG_GET_FIELD(status, VM_CONTEXT1_PROTECTION_FAULT_STATUS,

			      MEMORY_CLIENT_ID);

			      MEMORY_CLIENT_ID);





	printk("VM fault (0x%02x, vmid %d) at page %u, %s from '%s' (0x%08x) (%d)\n",

	dev_err(adev->dev, "VM fault (0x%02x, vmid %d) at page %u, %s from '%s' (0x%08x) (%d)\n",

	       protections, vmid, addr,

	       protections, vmid, addr,

	       REG_GET_FIELD(status, VM_CONTEXT1_PROTECTION_FAULT_STATUS,

	       REG_GET_FIELD(status, VM_CONTEXT1_PROTECTION_FAULT_STATUS,

			     MEMORY_CLIENT_RW) ?

			     MEMORY_CLIENT_RW) ?

drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -837,7 +837,7 @@ static void gmc_v8_0_vm_decode_fault(struct amdgpu_device *adev, 
	mc_id = REG_GET_FIELD(status, VM_CONTEXT1_PROTECTION_FAULT_STATUS,

	mc_id = REG_GET_FIELD(status, VM_CONTEXT1_PROTECTION_FAULT_STATUS,

			      MEMORY_CLIENT_ID);

			      MEMORY_CLIENT_ID);





	printk("VM fault (0x%02x, vmid %d) at page %u, %s from '%s' (0x%08x) (%d)\n",

	dev_err(adev->dev, "VM fault (0x%02x, vmid %d) at page %u, %s from '%s' (0x%08x) (%d)\n",

	       protections, vmid, addr,

	       protections, vmid, addr,

	       REG_GET_FIELD(status, VM_CONTEXT1_PROTECTION_FAULT_STATUS,

	       REG_GET_FIELD(status, VM_CONTEXT1_PROTECTION_FAULT_STATUS,

			     MEMORY_CLIENT_RW) ?

			     MEMORY_CLIENT_RW) ?

CRA Git | Maintained and supported by SUSTech CRA and CCSE