Commit b00e4814 authored Apr 03, 2014 by Joe Perches Committed by Linus Torvalds Apr 03, 2014

checkpatch: don't warn on bitfield spaces around :



This test prevents code from being aligned around the : for easy visual
counting of bitfield lengths.

ie:
	int foo		: 1,
	int bar		: 2,
	int foobar	:29;

should be acceptable so remove the test.

Signed-off-by: Joe Perches <joe@perches.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 91cb5195

scripts/checkpatch.pl

+5 −2

Original line number	Diff line number	Diff line
		@@ -3138,10 +3138,13 @@ sub process {
		# // is a comment
		} elsif ($op eq '//') {

		# : when part of a bitfield
		} elsif ($opv eq ':B') {
		# skip the bitfield test for now

		# No spaces for:
		# ->
		# : when part of a bitfield
		} elsif ($op eq '->' \|\| $opv eq ':B') {
		} elsif ($op eq '->') {
		if ($ctx =~ /Wx.\|.xW/) {
		if (ERROR("SPACING",
		"spaces prohibited around that '$op' $at\n" . $hereptr)) {

Admin message