Commit b00ccd0f authored May 27, 2007 by Jan Engelhardt Committed by David S. Miller May 29, 2007

[SPARC]: Linux always started with 9600 8N1



The Linux kernel ignored the PROM's serial settings (115200,n,8,1 in
my case). This was because mode_prop remained "ttyX-mode" (expected:
"ttya-mode") due to the constness of string literals when used with
"char *". Since there is no "ttyX-mode" property in the PROM, Linux
always used the default 9600.

[ Investigation of the suncore.s assembler reveals that gcc optimizied
  away the stores, yet did not emit a warning, which is a pretty
  anti-social thing to do and is the only reason this bug lived for
  so long -DaveM ]

Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7189859f

drivers/serial/suncore.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -30,9 +30,9 @@ void
		sunserial_console_termios(struct console *con)
		{
		char mode[16], buf[16], *s;
		char *mode_prop = "ttyX-mode";
		char *cd_prop = "ttyX-ignore-cd";
		char *dtr_prop = "ttyX-rts-dtr-off";
		char mode_prop[] = "ttyX-mode";
		char cd_prop[] = "ttyX-ignore-cd";
		char dtr_prop[] = "ttyX-rts-dtr-off";
		char *ssp_console_modes_prop = "ssp-console-modes";
		int baud, bits, stop, cflag;
		char parity;

Admin message