Commit b009c024 authored Jan 13, 2011 by Michel Lespinasse Committed by Linus Torvalds Jan 13, 2011

do_wp_page: remove the 'reuse' flag



mlocking a shared, writable vma currently causes the corresponding pages
to be marked as dirty and queued for writeback.  This seems rather
unnecessary given that the pages are not being actually modified during
mlock.  It is understood that for non-shared mappings (file or anon) we
want to use a write fault in order to break COW, but there is just no such
need for shared mappings.

The first two patches in this series do not introduce any behavior change.
 The intent there is to make it obvious that dirtying file pages is only
done in the (writable, shared) case.  I think this clarifies the code, but
I wouldn't mind dropping these two patches if there is no consensus about
them.

The last patch is where we actually avoid dirtying shared mappings during
mlock.  Note that as a side effect of this, we won't call page_mkwrite()
for the mappings that define it, and won't be pre-allocating data blocks
at the FS level if the mapped file was sparsely allocated.  My
understanding is that mlock does not need to provide such guarantee, as
evidenced by the fact that it never did for the filesystems that don't
define page_mkwrite() - including some common ones like ext3.  However, I
would like to gather feedback on this from filesystem people as a
precaution.  If this turns out to be a showstopper, maybe block
preallocation can be added back on using a different interface.

Large shared mlocks are getting significantly (>2x) faster in my tests, as
the disk can be fully used for reading the file instead of having to share
between this and writeback.

This patch:

Reorganize the code to remove the 'reuse' flag.  No behavior changes.

Signed-off-by: Michel Lespinasse <walken@google.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Kosaki Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Nick Piggin <npiggin@kernel.dk>
Cc: Theodore Tso <tytso@google.com>
Cc: Michael Rubin <mrubin@google.com>
Cc: Suleiman Souhlal <suleiman@google.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 212260aa

mm/memory.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -2112,7 +2112,7 @@ static int do_wp_page(struct mm_struct mm, struct vm_area_struct vma,
		{
		struct page old_page, new_page;
		pte_t entry;
		int reuse = 0, ret = 0;
		int ret = 0;
		int page_mkwrite = 0;
		struct page *dirty_page = NULL;

		@@ -2149,8 +2149,7 @@ static int do_wp_page(struct mm_struct mm, struct vm_area_struct vma,
		}
		page_cache_release(old_page);
		}
		reuse = reuse_swap_page(old_page);
		if (reuse)
		if (reuse_swap_page(old_page)) {
		/*
		* The page is all ours. Move it to our anon_vma so
		* the rmap code will not search our parent or siblings.
		@@ -2158,6 +2157,9 @@ static int do_wp_page(struct mm_struct mm, struct vm_area_struct vma,
		*/
		page_move_anon_rmap(old_page, vma, address);
		unlock_page(old_page);
		goto reuse;
		}
		unlock_page(old_page);
		} else if (unlikely((vma->vm_flags & (VM_WRITE\|VM_SHARED)) ==
		(VM_WRITE\|VM_SHARED))) {
		/*
		@@ -2220,10 +2222,7 @@ static int do_wp_page(struct mm_struct mm, struct vm_area_struct vma,
		}
		dirty_page = old_page;
		get_page(dirty_page);
		reuse = 1;
		}

		if (reuse) {
		reuse:
		flush_cache_page(vma, address, pte_pfn(orig_pte));
		entry = pte_mkyoung(orig_pte);

Admin message