Commit afffd3da authored Aug 30, 2009 by Bart Van Assche Committed by James Bottomley Sep 12, 2009

[SCSI] libsrp: fix memory leak in srp_ring_free()



This patch fixes a memory leak in the libsrp function srp_ring_free().
It is not documented whether or not this function should free the ring
pointer itself. But the source code of the callers of this function
(srp_target_alloc() and srp_target_free()) makes it clear that
srp_ring_free() should deallocate the ring pointer itself. Furthermore,
the patch below makes srp_ring_free() deallocate all memory allocated by
srp_ring_alloc().

This patch affects the ibmvstgt driver, which is the only in-tree driver
that calls the srp_ring_free() function (indirectly).

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent 661134ad

drivers/scsi/libsrp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -124,6 +124,7 @@ static void srp_ring_free(struct device dev, struct srp_buf *ring, size_t max,
		dma_free_coherent(dev, size, ring[i]->buf, ring[i]->dma);
		kfree(ring[i]);
		}
		kfree(ring);
		}

		int srp_target_alloc(struct srp_target target, struct device dev,

Admin message