Commit afea2ad5 authored by Paulo Zanoni's avatar Paulo Zanoni Committed by Dave Airlie
Browse files

drm: WARN() when drm_connector_attach_property fails 



Also return void instead of int. We have more than 100 callers and
no one checks for the return value.

If this function fails the property won't be exposed by the get/set
ioctls, but we should probably survive. If this starts happening,
the solution will be to increase DRM_CONNECTOR_MAX_PROPERTY and
recompile the Kernel.

Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: default avatarRob Clark <rob.clark@linaro.org>
Tested-by: default avatarRob Clark <rob.clark@linaro.org>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 26a34815

drivers/gpu/drm/drm_crtc.c

+5 −5
Original line number Diff line number Diff line
@@ -2819,7 +2819,7 @@ void drm_property_destroy(struct drm_device *dev, struct drm_property *property) 
}

EXPORT_SYMBOL(drm_property_destroy);



int drm_connector_attach_property(struct drm_connector *connector,

void drm_connector_attach_property(struct drm_connector *connector,

			       struct drm_property *property, uint64_t init_val)

{

	int i;
@@ -2828,13 +2828,13 @@ int drm_connector_attach_property(struct drm_connector *connector, 
		if (connector->property_ids[i] == 0) {

			connector->property_ids[i] = property->base.id;

			connector->property_values[i] = init_val;

			break;

			return;

		}

	}



	if (i == DRM_CONNECTOR_MAX_PROPERTY)

		return -EINVAL;

	return 0;

	WARN(1, "Failed to attach connector property. Please increase "

		"DRM_CONNECTOR_MAX_PROPERTY by 1 for each time you see this "

		"message\n");

}

EXPORT_SYMBOL(drm_connector_attach_property);

include/drm/drm_crtc.h

+2 −2
Original line number Diff line number Diff line
@@ -910,7 +910,7 @@ extern int drmfb_remove(struct drm_device *dev, struct drm_framebuffer *fb); 
extern void drm_crtc_probe_connector_modes(struct drm_device *dev, int maxX, int maxY);

extern bool drm_crtc_in_use(struct drm_crtc *crtc);



extern int drm_connector_attach_property(struct drm_connector *connector,

extern void drm_connector_attach_property(struct drm_connector *connector,

					  struct drm_property *property, uint64_t init_val);

extern struct drm_property *drm_property_create(struct drm_device *dev, int flags,

						const char *name, int num_values);

CRA Git | Maintained and supported by SUSTech CRA and CCSE