Commit afe6f1ee authored Jul 02, 2020 by Tony Lindgren

bus: ti-sysc: Fix sleeping function called from invalid context for RTC quirk



With CONFIG_DEBUG_ATOMIC_SLEEP enabled we can see the following with RTC probe:

BUG: sleeping function called from invalid context at drivers/bus/ti-sysc.c:1736
...
(sysc_quirk_rtc) from [<c060d01c>] (sysc_write_sysconfig+0x1c/0x60)
(sysc_write_sysconfig) from [<c060d9f4>] (sysc_enable_module+0x11c/0x274)
(sysc_enable_module) from [<c060f37c>] (sysc_probe+0xe9c/0x1380)
(sysc_probe) from [<c06e9384>] (platform_drv_probe+0x48/0x98)

Fixes: e8639e1c ("bus: ti-sysc: Handle module unlock quirk needed for some RTC")
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 9f911392

drivers/bus/ti-sysc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1727,7 +1727,7 @@ static void sysc_quirk_rtc(struct sysc *ddata, bool lock)

		local_irq_save(flags);
		/* RTC_STATUS BUSY bit may stay active for 1/32768 seconds (~30 usec) */
		error = readl_poll_timeout(ddata->module_va + 0x44, val,
		error = readl_poll_timeout_atomic(ddata->module_va + 0x44, val,
		!(val & BIT(0)), 100, 50);
		if (error)
		dev_warn(ddata->dev, "rtc busy timeout\n");

Admin message