Commit afe65e43 authored Dec 24, 2017 by Kishore KP Committed by Greg Kroah-Hartman Jan 08, 2018

staging: vc04_services: Prefer WARN_ON_ONCE instead of if condition followed by BUG.



Coccinelle suggested to use BUG_ON instead of if condition followed by BUG
but BUG_ON should be used in situations where integrity of the system is no
longer guaranteed. In this case, as suggested by Stefan Wahren, vchiq isn't
critical.
Since it is not critical, BUG_ON should be avoided.
Replaced if condition followed by BUG with WARN_ON_ONCE.

Signed-off-by: Kishore KP <kishore.p@techveda.org>
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 886654d7

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -224,8 +224,7 @@ vchiq_platform_get_arm_state(VCHIQ_STATE_T *state)

		platform_state = (struct vchiq_2835_state *)state->platform_state;

		if (!platform_state->inited)
		BUG();
		WARN_ON_ONCE(!platform_state->inited);

		return &platform_state->arm_state;
		}

Admin message