Commit afde94f3 authored Sep 26, 2007 by J. Bruce Fields Committed by Trond Myklebust Oct 09, 2007

SUNRPC: Fix default hostname created in rpc_create()



Since 43780b87..., rpc_create() fills in a default hostname based on
the ip address if the servername passed in is null.  A small typo made
that default incorrect.  (But this information appears to be used only
for debugging right now, so I don't believe the typo causes any bugs in
the current kernel.)

Thanks to Olga Kornievskaia for bug report and testing.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Cc: Olga Kornievskaia <aglo@citi.umich.edu>
Cc: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent bf19aace

net/sunrpc/clnt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -259,7 +259,7 @@ struct rpc_clnt rpc_create(struct rpc_create_args args)
		*/
		if (args->servername == NULL) {
		struct sockaddr_in *addr =
		(struct sockaddr_in *) &args->address;
		(struct sockaddr_in *) args->address;
		snprintf(servername, sizeof(servername), NIPQUAD_FMT,
		NIPQUAD(addr->sin_addr.s_addr));
		args->servername = servername;

Admin message