Commit afce6996 authored Aug 27, 2020 by Krzysztof Kozlowski Committed by Borislav Petkov Sep 01, 2020

EDAC/aspeed: Fix handling of platform_get_irq() error



platform_get_irq() returns a negative error number on error. In such a
case, comparison to 0 would pass the check therefore check the return
value properly, whether it is negative.

 [ bp: Massage commit message. ]

Fixes: 9b7e6242 ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Stefan Schaeckeler <schaecsn@gmx.net>
Link: https://lkml.kernel.org/r/20200827070743.26628-1-krzk@kernel.org

parent 857a3139

drivers/edac/aspeed_edac.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -209,8 +209,8 @@ static int config_irq(void ctx, struct platform_device pdev)
		/* register interrupt handler */
		irq = platform_get_irq(pdev, 0);
		dev_dbg(&pdev->dev, "got irq %d\n", irq);
		if (!irq)
		return -ENODEV;
		if (irq < 0)
		return irq;

		rc = devm_request_irq(&pdev->dev, irq, mcr_isr, IRQF_TRIGGER_HIGH,
		DRV_NAME, ctx);

Admin message