Commit afc3eda2 authored May 28, 2013 by Jaegeuk Kim

f2fs: fix incorrect iputs during the dentry recovery



- iget/iput flow in the dentry recovery process

1. *dir* = f2fs_iget
2. set FI_DELAY_IPUT to *dir*
3. add *dir* to the dirty_dir_list
		   - __f2fs_add_link
		     - recover_dentry)
4. iput *dir* by remove_dirty_dir_inode
		   - sync_dirty_dir_inodes
		     - write_chekcpoint

If *dir*'s i_count is not 1 (i.e., root dir), remove_dirty_dir_inode is called
later and then iput is triggered again due to the FI_DELAY_IPUT flag.
So, let's unset the flag properly once iput is triggered.

Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>

parent 6b8213d9

fs/f2fs/checkpoint.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -521,9 +521,11 @@ void remove_dirty_dir_inode(struct inode *inode)
		spin_unlock(&sbi->dir_inode_lock);

		/* Only from the recovery routine */
		if (is_inode_flag_set(F2FS_I(inode), FI_DELAY_IPUT))
		if (is_inode_flag_set(F2FS_I(inode), FI_DELAY_IPUT)) {
		clear_inode_flag(F2FS_I(inode), FI_DELAY_IPUT);
		iput(inode);
		}
		}

		struct inode check_dirty_dir_inode(struct f2fs_sb_info sbi, nid_t ino)
		{

Admin message