Commit af8ff049 authored Sep 20, 2009 by Eric Paris Committed by James Morris Sep 30, 2009

SELinux: reset the security_ops before flushing the avc cache

This patch resets the security_ops to the secondary_ops before it flushes
the avc. It's still possible that a task on another processor could have
already passed the security_ops dereference and be executing an selinux hook
function which would add a new avc entry. That entry would still not be
freed. This should however help to reduce the number of needless avcs the
kernel has when selinux is disabled at run time. There is no wasted
memory if selinux is disabled on the command line or not compiled.

Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>

parent 1669b049

security/selinux/hooks.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -5830,12 +5830,12 @@ int selinux_disable(void)
		selinux_disabled = 1;
		selinux_enabled = 0;

		/* Try to destroy the avc node cache */
		avc_disable();

		/* Reset security_ops to the secondary module, dummy or capability. */
		security_ops = secondary_ops;

		/* Try to destroy the avc node cache */
		avc_disable();

		/* Unregister netfilter hooks. */
		selinux_nf_ip_exit();

Admin message