Commit af8d8e6f authored by Guoqing Jiang's avatar Guoqing Jiang Committed by Shaohua Li
Browse files

md: changes for MD_STILL_CLOSED flag 



When stop clustered raid while it is pending on resync,
MD_STILL_CLOSED flag could be cleared since udev rule
is triggered to open the mddev. So obviously array can't
be stopped soon and returns EBUSY.

	mdadm -Ss          md-raid-arrays.rules
  set MD_STILL_CLOSED          md_open()
	... ... ...          clear MD_STILL_CLOSED
	do_md_stop

We make below changes to resolve this issue:

1. rename MD_STILL_CLOSED to MD_CLOSING since it is set
   when stop array and it means we are stopping array.
2. let md_open returns early if CLOSING is set, so no
   other threads will open array if one thread is trying
   to close it.
3. no need to clear CLOSING bit in md_open because 1 has
   ensure the bit is cleared, then we also don't need to
   test CLOSING bit in do_md_stop.

Reviewed-by: default avatarNeilBrown <neilb@suse.com>
Signed-off-by: default avatarGuoqing Jiang <gqjiang@suse.com>
Signed-off-by: default avatarShaohua Li <shli@fb.com>
parent e3f924d3

drivers/md/md.c

+8 −6
Original line number Diff line number Diff line
@@ -5573,8 +5573,7 @@ static int md_set_readonly(struct mddev *mddev, struct block_device *bdev) 
	mutex_lock(&mddev->open_mutex);

	if ((mddev->pers && atomic_read(&mddev->openers) > !!bdev) ||

	    mddev->sync_thread ||

	    test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) ||

	    (bdev && !test_bit(MD_STILL_CLOSED, &mddev->flags))) {

	    test_bit(MD_RECOVERY_RUNNING, &mddev->recovery)) {

		printk("md: %s still in use.\n",mdname(mddev));

		if (did_freeze) {

			clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
@@ -5636,8 +5635,7 @@ static int do_md_stop(struct mddev *mddev, int mode, 
	if ((mddev->pers && atomic_read(&mddev->openers) > !!bdev) ||

	    mddev->sysfs_active ||

	    mddev->sync_thread ||

	    test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) ||

	    (bdev && !test_bit(MD_STILL_CLOSED, &mddev->flags))) {

	    test_bit(MD_RECOVERY_RUNNING, &mddev->recovery)) {

		printk("md: %s still in use.\n",mdname(mddev));

		mutex_unlock(&mddev->open_mutex);

		if (did_freeze) {
@@ -6826,7 +6824,7 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode, 
			err = -EBUSY;

			goto out;

		}

		set_bit(MD_STILL_CLOSED, &mddev->flags);

		set_bit(MD_CLOSING, &mddev->flags);

		mutex_unlock(&mddev->open_mutex);

		sync_blockdev(bdev);

	}
@@ -7075,9 +7073,13 @@ static int md_open(struct block_device *bdev, fmode_t mode) 
	if ((err = mutex_lock_interruptible(&mddev->open_mutex)))

		goto out;



	if (test_bit(MD_CLOSING, &mddev->flags)) {

		mutex_unlock(&mddev->open_mutex);

		return -ENODEV;

	}



	err = 0;

	atomic_inc(&mddev->openers);

	clear_bit(MD_STILL_CLOSED, &mddev->flags);

	mutex_unlock(&mddev->open_mutex);



	check_disk_change(bdev);

drivers/md/md.h

+2 −3
Original line number Diff line number Diff line
@@ -201,9 +201,8 @@ struct mddev { 
#define MD_CHANGE_PENDING 2	/* switch from 'clean' to 'active' in progress */

#define MD_UPDATE_SB_FLAGS (1 | 2 | 4)	/* If these are set, md_update_sb needed */

#define MD_ARRAY_FIRST_USE 3    /* First use of array, needs initialization */

#define MD_STILL_CLOSED	4	/* If set, then array has not been opened since

				 * md_ioctl checked on it.

				 */

#define MD_CLOSING	4	/* If set, we are closing the array, do not open

				 * it then */

#define MD_JOURNAL_CLEAN 5	/* A raid with journal is already clean */

#define MD_HAS_JOURNAL	6	/* The raid array has journal feature set */

#define MD_RELOAD_SB	7	/* Reload the superblock because another node

CRA Git | Maintained and supported by SUSTech CRA and CCSE