Commit af736bf0 authored Feb 18, 2019 by Dan Carpenter Committed by David S. Miller Feb 21, 2019

net: sched: potential NULL dereference in tcf_block_find()

The error code isn't set on this path so it would result in returning
ERR_PTR(0) and a NULL dereference in the caller.

Fixes: 18d3eefb ("net: sched: refactor tcf_block_find() into standalone functions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 56b90fa0

net/sched/cls_api.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1309,8 +1309,10 @@ static struct tcf_block tcf_block_find(struct net net, struct Qdisc **q,
		goto errout_qdisc;

		block = __tcf_block_find(net, q, cl, ifindex, block_index, extack);
		if (IS_ERR(block))
		if (IS_ERR(block)) {
		err = PTR_ERR(block);
		goto errout_qdisc;
		}

		return block;