scsi: hpsa: Fix memory leak in hpsa_init_one() (af61bc1e) · Commits · 戴 / test

When hpsa_scsi_add_host() fails, h->lastlogicals is leaked since it is missing a free() in the error handler. Fix this by adding free() when hpsa_scsi_add_host() fails. Link: https://lore.kernel.org/r/20201027073125.14229-1-keitasuzuki.park@sslab.ics.keio.ac.jp Tested-by:

drivers/scsi/hpsa.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -8855,7 +8855,7 @@ reinit_after_soft_reset:
		/* hook into SCSI subsystem */
		rc = hpsa_scsi_add_host(h);
		if (rc)
		goto clean7; /* perf, sg, cmd, irq, shost, pci, lu, aer/h */
		goto clean8; /* lastlogicals, perf, sg, cmd, irq, shost, pci, lu, aer/h */

		/* Monitor the controller for firmware lockups */
		h->heartbeat_sample_interval = HEARTBEAT_SAMPLE_INTERVAL;
		@@ -8870,6 +8870,8 @@ reinit_after_soft_reset:
		HPSA_EVENT_MONITOR_INTERVAL);
		return 0;

		clean8: /* lastlogicals, perf, sg, cmd, irq, shost, pci, lu, aer/h */
		kfree(h->lastlogicals);
		clean7: /* perf, sg, cmd, irq, shost, pci, lu, aer/h */
		hpsa_free_performant_mode(h);
		h->access.set_intr_mask(h, HPSA_INTR_OFF);