Commit af3f606e authored Jul 30, 2018 by Lorenzo Pieralisi

PCI: mobiveil: Fix struct mobiveil_pcie.pcie_reg_base address type



The field pcie_reg_base in struct mobiveil_pcie represents a physical
address so it should be of phys_addr_t type rather than void __iomem*;
this results in the following compilation  warnings:

drivers/pci/controller/pcie-mobiveil.c: In function
'mobiveil_pcie_parse_dt':
drivers/pci/controller/pcie-mobiveil.c:326:22: warning: assignment makes
pointer from integer without a cast [-Wint-conversion]
  pcie->pcie_reg_base = res->start;
                      ^
drivers/pci/controller/pcie-mobiveil.c: In function
'mobiveil_pcie_enable_msi':
drivers/pci/controller/pcie-mobiveil.c:485:25: warning: initialization
makes integer from pointer without a cast [-Wint-conversion]
  phys_addr_t msg_addr = pcie->pcie_reg_base;
                         ^~~~
drivers/pci/controller/pcie-mobiveil.c: In function
'mobiveil_compose_msi_msg':
drivers/pci/controller/pcie-mobiveil.c:640:21: warning: initialization
makes integer from pointer without a cast [-Wint-conversion]
  phys_addr_t addr = pcie->pcie_reg_base + (data->hwirq * sizeof(int));

Fix the type and with it the compilation warnings.

Fixes: 9af6bcb1 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP
driver")
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>

parent 01456207

drivers/pci/controller/pcie-mobiveil.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -130,7 +130,7 @@ struct mobiveil_pcie {
		void __iomem config_axi_slave_base; / endpoint config base */
		void __iomem csr_axi_slave_base; / root port config base */
		void __iomem apb_csr_base; / MSI register base */
		void __iomem pcie_reg_base; / Physical PCIe Controller Base */
		phys_addr_t pcie_reg_base; /* Physical PCIe Controller Base */
		struct irq_domain *intx_domain;
		raw_spinlock_t intx_mask_lock;
		int irq;

Admin message