Commit af3be70a authored Apr 03, 2019 by Florian Fainelli Committed by Rob Herring Apr 10, 2019

of: Improve of_phandle_iterator_next() error message



Understanding why of_phandle_iterator_next() returns an error can
sometimes be hard to decipher based solely on the error message, a
typical error example is that #foo-cells = <X> and the phandle property
used has a smaller number of cells specified, e.g.:

	#thermal-sensor-cells = <1>;
	phandle = <&scmi_sensor>

instead of:

	phandle <&scmi_sensor 0>;

Instead, make it clear what the expectations are towards debugging
incorrect Device Tree faster:

OF: /thermal-zones/scmi-thermal: #thermal-sensor-cells = 1, found 0 instead

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>

parent 12eeae71

drivers/of/base.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1350,8 +1350,9 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it)
		* property data length
		*/
		if (it->cur + count > it->list_end) {
		pr_err("%pOF: arguments longer than property\n",
		it->parent);
		pr_err("%pOF: %s = %d found %d\n",
		it->parent, it->cells_name,
		count, it->cell_count);
		goto err;
		}
		}

Admin message