Commit af2e8409 authored May 29, 2012 by Paul Gortmaker Committed by Linus Torvalds May 29, 2012

pagemap.h: fix warning about possibly used before init var



Commit f56f821f ("mm: extend prefault helpers to fault in more than
PAGE_SIZE") added in the new functions: fault_in_multipages_writeable()
and fault_in_multipages_readable().

However, we currently see:

  include/linux/pagemap.h:492: warning: 'ret' may be used uninitialized in this function
  include/linux/pagemap.h:492: note: 'ret' was declared here

Unlike a lot of gcc nags, this one appears somewhat legit.  i.e.  passing
in an invalid negative value of "size" does make it look like all the
conditionals in there would be bypassed and the uninitialized value would
be returned.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4b781474

include/linux/pagemap.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -460,11 +460,11 @@ static inline int fault_in_pages_readable(const char __user *uaddr, int size)
		*/
		static inline int fault_in_multipages_writeable(char __user *uaddr, int size)
		{
		int ret;
		int ret = 0;
		char __user *end = uaddr + size - 1;

		if (unlikely(size == 0))
		return 0;
		return ret;

		/*
		* Writing zeroes into userspace here is OK, because we know that if
		@@ -489,11 +489,11 @@ static inline int fault_in_multipages_readable(const char __user *uaddr,
		int size)
		{
		volatile char c;
		int ret;
		int ret = 0;
		const char __user *end = uaddr + size - 1;

		if (unlikely(size == 0))
		return 0;
		return ret;

		while (uaddr <= end) {
		ret = __get_user(c, uaddr);

Admin message