Commit af1ce6b2 authored May 24, 2011 by Jingoo Han Committed by Paul Mundt May 24, 2011

video: s3c-fb: correct transparency checking in 32bpp



32bpp means ARGB 8888 in the driver, therfore the transparency length
and offset should be 8 and 24 respectively. However, the transparency
length and offset were previously 0, which means that the driver supports
RGB 888 without alpha blending when 32bpp is used.

So, the transparency checking in 32bpp is corrected so that the
transparency length and offset are 8 and 24 respectively.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>

parent 6aa96811

drivers/video/s3c-fb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -302,6 +302,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var,
		var->blue.length = 5;
		break;

		case 32:
		case 28:
		case 25:
		var->transp.length = var->bits_per_pixel - 24;
		@@ -310,7 +311,6 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var,
		case 24:
		/* our 24bpp is unpacked, so 32bpp */
		var->bits_per_pixel = 32;
		case 32:
		var->red.offset = 16;
		var->red.length = 8;
		var->green.offset = 8;

Admin message