Commit af19edf7 authored Sep 04, 2018 by Takashi Iwai Committed by Greg Kroah-Hartman Sep 10, 2018

staging: bcm2835-audio: Drop unnecessary pcm indirect setup



The hw_queue_size of PCM indirect helper doesn't need to be set up if
you use the whole given buffer size.  Drop the useless
initialization, which just confuses readers.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5d0be6da

drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -280,7 +280,6 @@ static int snd_bcm2835_pcm_ack(struct snd_pcm_substream *substream)
		struct bcm2835_alsa_stream *alsa_stream = runtime->private_data;
		struct snd_pcm_indirect *pcm_indirect = &alsa_stream->pcm_indirect;

		pcm_indirect->hw_queue_size = runtime->hw.buffer_bytes_max;
		return snd_pcm_indirect_playback_transfer(substream, pcm_indirect,
		snd_bcm2835_pcm_transfer);
		}

Admin message