Commit aef29bc2 authored Jun 29, 2009 by Alan Cox Committed by Linus Torvalds Jun 29, 2009

tty: Fix the leak in tty_ldisc_release



Currently we reinit the ldisc on final tty close which is what the old code
did to ensure that if the device retained its termios settings then it had the
right ldisc. tty_ldisc_reinit does that but also leaves us with the reset
ldisc reference which is then leaked.

At this point we know the port will be recycled so we can kill the ldisc
off completely rather than try and add another ldisc free up when the kref
count hits zero.

At this point it is safe to keep the ldisc closed as tty_ldisc waiting
methods are only used from the user side, and as the final close we are
the last such reference. Interrupt/driver side methods will always use the
non wait version and get back a NULL.

Found with kmemleak and investigated/identified by Catalin Marinas.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 52989765

drivers/char/tty_ldisc.c

+11 −4

Original line number	Diff line number	Diff line
		@@ -867,15 +867,22 @@ void tty_ldisc_release(struct tty_struct tty, struct tty_struct o_tty)
		tty_ldisc_wait_idle(tty);

		/*
		* Shutdown the current line discipline, and reset it to N_TTY.
		*
		* FIXME: this MUST get fixed for the new reflocking
		* Now kill off the ldisc
		*/
		tty_ldisc_close(tty, tty->ldisc);
		tty_ldisc_put(tty->ldisc);
		/* Force an oops if we mess this up */
		tty->ldisc = NULL;

		/* Ensure the next open requests the N_TTY ldisc */
		tty_set_termios_ldisc(tty, N_TTY);

		tty_ldisc_reinit(tty);
		/* This will need doing differently if we need to lock */
		if (o_tty)
		tty_ldisc_release(o_tty, NULL);

		/* And the memory resources remaining (buffers, termios) will be
		disposed of when the kref hits zero */
		}

		/**

Admin message