Commit aeebc6ba authored Dec 06, 2017 by Arnd Bergmann Committed by Wim Van Sebroeck Dec 28, 2017

watchdog: hpwdt: fix unused variable warning



The new hpwdt_my_nmi() function is used conditionally, which produces
a harmless warning in some configurations:

drivers/watchdog/hpwdt.c:478:12: error: 'hpwdt_my_nmi' defined but not used [-Werror=unused-function]

This moves it inside of the #ifdef that protects its caller, to silence
the warning.

Fixes: 621174a92851 ("watchdog: hpwdt: Check source of NMI")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

parent 13983959

drivers/watchdog/hpwdt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -475,12 +475,12 @@ static int hpwdt_time_left(void)
		return TICKS_TO_SECS(ioread16(hpwdt_timer_reg));
		}

		#ifdef CONFIG_HPWDT_NMI_DECODING
		static int hpwdt_my_nmi(void)
		{
		return ioread8(hpwdt_nmistat) & 0x6;
		}

		#ifdef CONFIG_HPWDT_NMI_DECODING
		/*
		* NMI Handler
		*/

Admin message