ARM/orion/gpio: Make use of for_each_requested_gpio() (aed8fa12) · Commits · 戴 / test

Make use of for_each_requested_gpio() instead of home grown analogue. Signed-off-by:

Andrew Lunn <andrew@lunn.ch> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Cc: Gregory Clement <gregory.clement@bootlin.com> Link: https://lore.kernel.org/r/20200615150545.87964-3-andriy.shevchenko@linux.intel.com Signed-off-by:

arch/arm/plat-orion/gpio.c

+2 −6

Original line number	Original line	Diff line number	Diff line
	@@ -442,6 +442,7 @@ static void orion_gpio_dbg_show(struct seq_file s, struct gpio_chip chip)

	struct orion_gpio_chip *ochip = gpiochip_get_data(chip);		struct orion_gpio_chip *ochip = gpiochip_get_data(chip);
	u32 out, io_conf, blink, in_pol, data_in, cause, edg_msk, lvl_msk;		u32 out, io_conf, blink, in_pol, data_in, cause, edg_msk, lvl_msk;
			const char *label;
	int i;		int i;

	out = readl_relaxed(GPIO_OUT(ochip));		out = readl_relaxed(GPIO_OUT(ochip));
	@@ -453,15 +454,10 @@ static void orion_gpio_dbg_show(struct seq_file s, struct gpio_chip chip)
	edg_msk = readl_relaxed(GPIO_EDGE_MASK(ochip));		edg_msk = readl_relaxed(GPIO_EDGE_MASK(ochip));
	lvl_msk = readl_relaxed(GPIO_LEVEL_MASK(ochip));		lvl_msk = readl_relaxed(GPIO_LEVEL_MASK(ochip));

	for (i = 0; i < chip->ngpio; i++) {		for_each_requested_gpio(chip, i, label) {
	const char *label;
	u32 msk;		u32 msk;
	bool is_out;		bool is_out;

	label = gpiochip_is_requested(chip, i);
	if (!label)
	continue;

	msk = 1 << i;		msk = 1 << i;
	is_out = !(io_conf & msk);		is_out = !(io_conf & msk);