Commit aec429e0 authored Sep 02, 2020 by Krzysztof Kozlowski Committed by Ulf Hansson Sep 07, 2020

mmc: bcm2835: Simplify with dev_err_probe()



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20200902193658.20539-2-krzk@kernel.org


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent fa2d0aa9

drivers/mmc/host/bcm2835.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1406,9 +1406,7 @@ static int bcm2835_probe(struct platform_device *pdev)

		clk = devm_clk_get(dev, NULL);
		if (IS_ERR(clk)) {
		ret = PTR_ERR(clk);
		if (ret != -EPROBE_DEFER)
		dev_err(dev, "could not get clk: %d\n", ret);
		ret = dev_err_probe(dev, PTR_ERR(clk), "could not get clk\n");
		goto err;
		}

Admin message