Commit aeae4f3e authored Sep 04, 2018 by Lukas Wunner Committed by Bjorn Helgaas Sep 17, 2018

PCI/ASPM: Fix link_state teardown on device removal



Upon removal of the last device on a bus, the link_state of the bridge
leading to that bus is sought to be torn down by having pci_stop_dev()
call pcie_aspm_exit_link_state().

When ASPM was originally introduced by commit 7d715a6c ("PCI: add
PCI Express ASPM support"), it determined whether the device being
removed is the last one by calling list_empty() on the bridge's
subordinate devices list.  That didn't work because the device is only
removed from the list slightly later in pci_destroy_dev().

Commit 3419c75e ("PCI: properly clean up ASPM link state on device
remove") attempted to fix it by calling list_is_last(), but that's not
correct either because it checks whether the device is at the *end* of
the list, not whether it's the last one *left* in the list.  If the user
removes the device which happens to be at the end of the list via sysfs
but other devices are preceding the device in the list, the link_state
is torn down prematurely.

The real fix is to move the invocation of pcie_aspm_exit_link_state() to
pci_destroy_dev() and reinstate the call to list_empty().  Remove a
duplicate check for dev->bus->self because pcie_aspm_exit_link_state()
already contains an identical check.

Fixes: 7d715a6c ("PCI: add PCI Express ASPM support")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Shaohua Li <shaohua.li@intel.com>
Cc: stable@vger.kernel.org # v2.6.26

parent 7876320f

drivers/pci/pcie/aspm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -991,7 +991,7 @@ void pcie_aspm_exit_link_state(struct pci_dev *pdev)
		* All PCIe functions are in one slot, remove one function will remove
		* the whole slot, so just wait until we are the last function left.
		*/
		if (!list_is_last(&pdev->bus_list, &parent->subordinate->devices))
		if (!list_empty(&parent->subordinate->devices))
		goto out;

		link = parent->link_state;

drivers/pci/remove.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -25,9 +25,6 @@ static void pci_stop_dev(struct pci_dev *dev)

		pci_dev_assign_added(dev, false);
		}

		if (dev->bus->self)
		pcie_aspm_exit_link_state(dev);
		}

		static void pci_destroy_dev(struct pci_dev *dev)
		@@ -41,6 +38,7 @@ static void pci_destroy_dev(struct pci_dev *dev)
		list_del(&dev->bus_list);
		up_write(&pci_bus_sem);

		pcie_aspm_exit_link_state(dev);
		pci_bridge_d3_update(dev);
		pci_free_resources(dev);
		put_device(&dev->dev);

Admin message