Commit ae93a6c7 authored May 10, 2016 by Chris Phlipot Committed by Arnaldo Carvalho de Melo May 11, 2016

perf symbols: Add dso__insert_symbol function



The current method for inserting symbols is to use the symbols__insert()
function. However symbols__insert() does not update the dso symbol
cache.  This causes problems in the following scenario:

1. symbol not found at addr using dso__find_symbol

2. symbol inserted at addr using the existing symbols__insert function

3. symbol still not found at addr using dso__find_symbol() because cache isn't
   updated. This is undesired behavior.

The undesired behavior in (3) is addressed by creating a new function,
dso__insert_symbol() to both insert the symbol and update the symbol
cache if necessary.

If dso__insert_symbol() is used in (2) instead of symbols__insert(),
then the undesired behavior in (3) is avoided.

Signed-off-by: Chris Phlipot <cphlipot0@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1462937209-6032-2-git-send-email-cphlipot0@gmail.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 62665dff

tools/perf/util/symbol.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -413,6 +413,18 @@ void dso__reset_find_symbol_cache(struct dso *dso)
		}
		}

		void dso__insert_symbol(struct dso dso, enum map_type type, struct symbol sym)
		{
		symbols__insert(&dso->symbols[type], sym);

		/* update the symbol cache if necessary */
		if (dso->last_find_result[type].addr >= sym->start &&
		(dso->last_find_result[type].addr < sym->end \|\|
		sym->start == sym->end)) {
		dso->last_find_result[type].symbol = sym;
		}
		}

		struct symbol dso__find_symbol(struct dso dso,
		enum map_type type, u64 addr)
		{

tools/perf/util/symbol.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -246,6 +246,9 @@ int __dso__load_kallsyms(struct dso dso, const char filename, struct map *map,
		int dso__load_kallsyms(struct dso dso, const char filename, struct map *map,
		symbol_filter_t filter);

		void dso__insert_symbol(struct dso *dso, enum map_type type,
		struct symbol *sym);

		struct symbol dso__find_symbol(struct dso dso, enum map_type type,
		u64 addr);
		struct symbol dso__find_symbol_by_name(struct dso dso, enum map_type type,

Admin message