Commit ae91c925 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

debugfs: remove return value of debugfs_create_regset32() 

No one checks the return value of debugfs_create_regset32(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Link: https://lore.kernel.org/r/20191122104453.GA2017837@kroah.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bb6d3fb3

Documentation/filesystems/debugfs.txt

+3 −3
Original line number Diff line number Diff line
@@ -164,7 +164,7 @@ file. 
	void __iomem *base;

    };



    struct dentry *debugfs_create_regset32(const char *name, umode_t mode,

    debugfs_create_regset32(const char *name, umode_t mode,

			    struct dentry *parent,

			    struct debugfs_regset32 *regset);

fs/debugfs/file.c

+4 −13
Original line number Diff line number Diff line
@@ -1090,21 +1090,12 @@ static const struct file_operations fops_regset32 = { 
 * This function creates a file in debugfs with the given name that reports

 * the names and values of a set of 32-bit registers. If the @mode variable

 * is so set it can be read from. Writing is not supported.

 *

 * This function will return a pointer to a dentry if it succeeds.  This

 * pointer must be passed to the debugfs_remove() function when the file is

 * to be removed (no automatic cleanup happens if your module is unloaded,

 * you are responsible here.)  If an error occurs, ERR_PTR(-ERROR) will be

 * returned.

 *

 * If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will

 * be returned.

 */

struct dentry *debugfs_create_regset32(const char *name, umode_t mode,

void debugfs_create_regset32(const char *name, umode_t mode,

			     struct dentry *parent,

			     struct debugfs_regset32 *regset)

{

	return debugfs_create_file(name, mode, parent, regset, &fops_regset32);

	debugfs_create_file(name, mode, parent, regset, &fops_regset32);

}

EXPORT_SYMBOL_GPL(debugfs_create_regset32);

include/linux/debugfs.h

+6 −7
Original line number Diff line number Diff line
@@ -127,7 +127,7 @@ struct dentry *debugfs_create_blob(const char *name, umode_t mode, 
				  struct dentry *parent,

				  struct debugfs_blob_wrapper *blob);



struct dentry *debugfs_create_regset32(const char *name, umode_t mode,

void debugfs_create_regset32(const char *name, umode_t mode,

			     struct dentry *parent,

			     struct debugfs_regset32 *regset);
@@ -304,11 +304,10 @@ static inline struct dentry *debugfs_create_blob(const char *name, umode_t mode, 
	return ERR_PTR(-ENODEV);

}



static inline struct dentry *debugfs_create_regset32(const char *name,

				   umode_t mode, struct dentry *parent,

static inline void debugfs_create_regset32(const char *name, umode_t mode,

					   struct dentry *parent,

					   struct debugfs_regset32 *regset)

{

	return ERR_PTR(-ENODEV);

}



static inline void debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs,

CRA Git | Maintained and supported by SUSTech CRA and CCSE