ASoC: intel: skylake: Remove superfluous bus ops (ae91a189) · Commits · 戴 / test

The bus_core_ops values set in skl driver are same as the default values, so we can drop it and pass NULL to snd_hdac_ext_bus_init() instead. Signed-off-by:

Takashi Iwai <tiwai@suse.de> Link: https://lore.kernel.org/r/20191212191747.19995-1-tiwai@suse.de Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/intel/skylake/skl.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -773,11 +773,6 @@ static void skl_codec_create(struct hdac_bus *bus)
		}
		}

		static const struct hdac_bus_ops bus_core_ops = {
		.command = snd_hdac_bus_send_cmd,
		.get_response = snd_hdac_bus_get_response,
		};

		static int skl_i915_init(struct hdac_bus *bus)
		{
		int err;
		@@ -888,7 +883,7 @@ static int skl_create(struct pci_dev *pci,
		#if IS_ENABLED(CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC)
		ext_ops = snd_soc_hdac_hda_get_ops();
		#endif
		snd_hdac_ext_bus_init(bus, &pci->dev, &bus_core_ops, ext_ops);
		snd_hdac_ext_bus_init(bus, &pci->dev, NULL, ext_ops);
		bus->use_posbuf = 1;
		skl->pci = pci;
		INIT_WORK(&skl->probe_work, skl_probe_work);

Admin message