Commit ae7d2923 authored May 19, 2020 by Wei Yongjun Committed by Joerg Roedel May 19, 2020

iommu/sun50i: Fix return value check in sun50i_iommu_probe()



In case of error, the function devm_platform_ioremap_resource() returns
ERR_PTR() not NULL. The NULL test in the return value check must be
replaced with IS_ERR().

Fixes: 4100b8c2 ("iommu: Add Allwinner H6 IOMMU driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20200519091857.134170-1-weiyongjun1@huawei.com


Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent 38b91f81

drivers/iommu/sun50i-iommu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -941,7 +941,7 @@ static int sun50i_iommu_probe(struct platform_device *pdev)
		}

		iommu->base = devm_platform_ioremap_resource(pdev, 0);
		if (!iommu->base) {
		if (IS_ERR(iommu->base)) {
		ret = PTR_ERR(iommu->base);
		goto err_free_group;
		}

Admin message