Commit ae5dd5fc authored Apr 08, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman Apr 08, 2013

staging: comedi: drivers: dev->board_name is always valid



The dev->board_name is always initialized before calling the(*attach)
or (*auto_attach) function. The "BUG" check in comedi_device_postconfig()
is no longer necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 34b68400

drivers/staging/comedi/drivers.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -272,13 +272,8 @@ static int comedi_device_postconfig(struct comedi_device *dev)
		int ret;

		ret = __comedi_device_postconfig(dev);
		if (ret < 0) {
		if (ret < 0)
		return ret;
		}
		if (!dev->board_name) {
		dev_warn(dev->class_dev, "BUG: dev->board_name=NULL\n");
		dev->board_name = "BUG";
		}
		smp_wmb();
		dev->attached = true;
		return 0;

Admin message