Commit ae4611f1 authored by Nicholas Johnson's avatar Nicholas Johnson Committed by Bjorn Helgaas
Browse files

PCI: Set resource size directly in adjust_bridge_window() 

Change adjust_bridge_window() to set resource size directly instead of
using additional resource lists.

Because additional resource lists are optional resources, any algorithm
that requires guaranteed allocation that uses them cannot be guaranteed to
work.

Remove the resource from add_list, as a zero-sized additional resource is
redundant.

Update comment in pci_bus_distribute_available_resources() to reflect the
above changes.

Link: https://lore.kernel.org/r/PSXP216MB04386BA48874B56BC5CB0292803C0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM


Signed-off-by: default avatarNicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 1e58f4e1

drivers/pci/setup-bus.c

+7 −16
Original line number Diff line number Diff line
@@ -1842,7 +1842,7 @@ static void adjust_bridge_window(struct pci_dev *bridge, struct resource *res, 
				 struct list_head *add_list,

				 resource_size_t new_size)

{

	struct pci_dev_resource *dev_res;

	resource_size_t add_size;



	if (res->parent)

		return;
@@ -1850,17 +1850,10 @@ static void adjust_bridge_window(struct pci_dev *bridge, struct resource *res, 
	if (resource_size(res) >= new_size)

		return;



	dev_res = res_to_dev_res(add_list, res);

	if (!dev_res)

		return;



	/* Is there room to extend the window? */

	if (new_size - resource_size(res) <= dev_res->add_size)

		return;



	dev_res->add_size = new_size - resource_size(res);

	pci_dbg(bridge, "bridge window %pR extended by %pa\n", res,

		&dev_res->add_size);

	add_size = new_size - resource_size(res);

	pci_dbg(bridge, "bridge window %pR extended by %pa\n", res, &add_size);

	res->end = res->start + new_size - 1;

	remove_from_list(add_list, res);

}



static void pci_bus_distribute_available_resources(struct pci_bus *bus,
@@ -1896,10 +1889,8 @@ static void pci_bus_distribute_available_resources(struct pci_bus *bus, 
			mmio_pref.end + 1);



	/*

	 * Update additional resource list (add_list) to fill all the

	 * extra resource space available for this port except the space

	 * calculated in __pci_bus_size_bridges() which covers all the

	 * devices currently connected to the port and below.

	 * Now that we have adjusted for alignment, update the bridge window

	 * resources to fill as much remaining resource space as possible.

	 */

	adjust_bridge_window(bridge, io_res, add_list, resource_size(&io));

	adjust_bridge_window(bridge, mmio_res, add_list, resource_size(&mmio));

CRA Git | Maintained and supported by SUSTech CRA and CCSE