Commit ae2bdbb4 authored Aug 02, 2019 by Henry Tieman Committed by Jeff Kirsher Aug 26, 2019

ice: fix adminq calls during remove



The order of operations was incorrect in ice_remove(). The code would
try to use adminq operations after the adminq was disabled. This caused
all adminq calls to fail and possibly timeout waiting.

Signed-off-by: Henry Tieman <henry.w.tieman@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 152b978a

drivers/net/ethernet/intel/ice/ice_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2633,9 +2633,9 @@ static void ice_remove(struct pci_dev *pdev)
		continue;
		ice_vsi_free_q_vectors(pf->vsi[i]);
		}
		ice_clear_interrupt_scheme(pf);
		ice_deinit_pf(pf);
		ice_deinit_hw(&pf->hw);
		ice_clear_interrupt_scheme(pf);
		pci_disable_pcie_error_reporting(pdev);
		}

Admin message