Commit ae1b6a31 authored Apr 12, 2008 by Pavel Emelyanov Committed by David S. Miller Apr 12, 2008

[AX25]: Potential ax25_uid_assoc-s leaks on module unload.



The ax25_uid_free call walks the ax25_uid_list and releases entries
from it. The problem is that after the fisrt call to hlist_del_init
the hlist_for_each_entry (which hides behind the ax25_uid_for_each)
will consider the current position to be the last and will return.

Thus, the whole list will be left not freed.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2de58e30

net/ax25/ax25_uid.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -218,9 +218,11 @@ void __exit ax25_uid_free(void)
		struct hlist_node *node;

		write_lock(&ax25_uid_lock);
		again:
		ax25_uid_for_each(ax25_uid, node, &ax25_uid_list) {
		hlist_del_init(&ax25_uid->uid_node);
		ax25_uid_put(ax25_uid);
		goto again;
		}
		write_unlock(&ax25_uid_lock);
		}

Admin message