Commit ae133733 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge branch 'x86-acpi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 

Pull x86 acpi fixes from Thomas Gleixner:
 "This update deals with the fallout of the recent work to make
  cpuid/node mappings persistent.

  It turned out that the boot time ACPI based mapping tripped over ACPI
  inconsistencies and caused regressions. It's partially reverted and
  the fragile part replaced by an implementation which makes the mapping
  persistent when a CPU goes online for the first time"

* 'x86-acpi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  acpi/processor: Check for duplicate processor ids at hotplug time
  acpi/processor: Implement DEVICE operator for processor enumeration
  x86/acpi: Restore the order of CPU IDs
  Revert"x86/acpi: Enable MADT APIs to return disabled apicids"
  Revert "x86/acpi: Set persistent cpuid <-> nodeid mapping when booting"
parents a7fc726b a77d6cd9

arch/x86/kernel/acpi/boot.c

+7 −2
Original line number Diff line number Diff line
@@ -179,10 +179,15 @@ static int acpi_register_lapic(int id, u32 acpiid, u8 enabled) 
		return -EINVAL;

	}



	if (!enabled) {

		++disabled_cpus;

		return -EINVAL;

	}



	if (boot_cpu_physical_apicid != -1U)

		ver = boot_cpu_apic_version;



	cpu = __generic_processor_info(id, ver, enabled);

	cpu = generic_processor_info(id, ver);

	if (cpu >= 0)

		early_per_cpu(x86_cpu_to_acpiid, cpu) = acpiid;
@@ -710,7 +715,7 @@ static void __init acpi_set_irq_model_ioapic(void) 
#ifdef CONFIG_ACPI_HOTPLUG_CPU

#include <acpi/processor.h>



int acpi_map_cpu2node(acpi_handle handle, int cpu, int physid)

static int acpi_map_cpu2node(acpi_handle handle, int cpu, int physid)

{

#ifdef CONFIG_ACPI_NUMA

	int nid;

arch/x86/kernel/apic/apic.c

+7 −19
Original line number Diff line number Diff line
@@ -2063,7 +2063,7 @@ static int allocate_logical_cpuid(int apicid) 
	return nr_logical_cpuids++;

}



int __generic_processor_info(int apicid, int version, bool enabled)

int generic_processor_info(int apicid, int version)

{

	int cpu, max = nr_cpu_ids;

	bool boot_cpu_detected = physid_isset(boot_cpu_physical_apicid,
@@ -2121,11 +2121,9 @@ int __generic_processor_info(int apicid, int version, bool enabled) 
	if (num_processors >= nr_cpu_ids) {

		int thiscpu = max + disabled_cpus;



		if (enabled) {

		pr_warning("APIC: NR_CPUS/possible_cpus limit of %i "

			   "reached. Processor %d/0x%x ignored.\n",

			   max, thiscpu, apicid);

		}



		disabled_cpus++;

		return -EINVAL;
@@ -2177,23 +2175,13 @@ int __generic_processor_info(int apicid, int version, bool enabled) 
		apic->x86_32_early_logical_apicid(cpu);

#endif

	set_cpu_possible(cpu, true);



	if (enabled) {

		num_processors++;

	physid_set(apicid, phys_cpu_present_map);

	set_cpu_present(cpu, true);

	} else {

		disabled_cpus++;

	}

	num_processors++;



	return cpu;

}



int generic_processor_info(int apicid, int version)

{

	return __generic_processor_info(apicid, version, true);

}



int hard_smp_processor_id(void)

{

	return read_apic_id();

drivers/acpi/acpi_processor.c

+42 −15
Original line number Diff line number Diff line
@@ -182,11 +182,6 @@ int __weak arch_register_cpu(int cpu) 


void __weak arch_unregister_cpu(int cpu) {}



int __weak acpi_map_cpu2node(acpi_handle handle, int cpu, int physid)

{

	return -ENODEV;

}



static int acpi_processor_hotadd_init(struct acpi_processor *pr)

{

	unsigned long long sta;
@@ -285,6 +280,13 @@ static int acpi_processor_get_info(struct acpi_device *device) 
		pr->acpi_id = value;

	}



	if (acpi_duplicate_processor_id(pr->acpi_id)) {

		dev_err(&device->dev,

			"Failed to get unique processor _UID (0x%x)\n",

			pr->acpi_id);

		return -ENODEV;

	}



	pr->phys_id = acpi_get_phys_id(pr->handle, device_declaration,

					pr->acpi_id);

	if (invalid_phys_cpuid(pr->phys_id))
@@ -585,7 +587,7 @@ static struct acpi_scan_handler processor_container_handler = { 
static int nr_unique_ids __initdata;



/* The number of the duplicate processor IDs */

static int nr_duplicate_ids __initdata;

static int nr_duplicate_ids;



/* Used to store the unique processor IDs */

static int unique_processor_ids[] __initdata = {
@@ -593,7 +595,7 @@ static int unique_processor_ids[] __initdata = { 
};



/* Used to store the duplicate processor IDs */

static int duplicate_processor_ids[] __initdata = {

static int duplicate_processor_ids[] = {

	[0 ... NR_CPUS - 1] = -1,

};
@@ -638,28 +640,53 @@ static acpi_status __init acpi_processor_ids_walk(acpi_handle handle, 
						  void **rv)

{

	acpi_status status;

	acpi_object_type acpi_type;

	unsigned long long uid;

	union acpi_object object = { 0 };

	struct acpi_buffer buffer = { sizeof(union acpi_object), &object };



	status = acpi_get_type(handle, &acpi_type);

	if (ACPI_FAILURE(status))

		return false;



	switch (acpi_type) {

	case ACPI_TYPE_PROCESSOR:

		status = acpi_evaluate_object(handle, NULL, NULL, &buffer);

		if (ACPI_FAILURE(status))

		acpi_handle_info(handle, "Not get the processor object\n");

	else

		processor_validated_ids_update(object.processor.proc_id);

			goto err;

		uid = object.processor.proc_id;

		break;



	case ACPI_TYPE_DEVICE:

		status = acpi_evaluate_integer(handle, "_UID", NULL, &uid);

		if (ACPI_FAILURE(status))

			goto err;

		break;

	default:

		goto err;

	}



	processor_validated_ids_update(uid);

	return true;



err:

	acpi_handle_info(handle, "Invalid processor object\n");

	return false;



	return AE_OK;

}



static void __init acpi_processor_check_duplicates(void)

void __init acpi_processor_check_duplicates(void)

{

	/* Search all processor nodes in ACPI namespace */

	/* check the correctness for all processors in ACPI namespace */

	acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,

						ACPI_UINT32_MAX,

						acpi_processor_ids_walk,

						NULL, NULL, NULL);

	acpi_get_devices(ACPI_PROCESSOR_DEVICE_HID, acpi_processor_ids_walk,

						NULL, NULL);

}



bool __init acpi_processor_validate_proc_id(int proc_id)

bool acpi_duplicate_processor_id(int proc_id)

{

	int i;

drivers/acpi/bus.c

+0 −1
Original line number Diff line number Diff line
@@ -1249,7 +1249,6 @@ static int __init acpi_init(void) 
	acpi_wakeup_device_init();

	acpi_debugger_init();

	acpi_setup_sb_notify_handler();

	acpi_set_processor_mapping();

	return 0;

}

drivers/acpi/processor_core.c

+22 −111
Original line number Diff line number Diff line
@@ -32,12 +32,12 @@ static struct acpi_table_madt *get_madt_table(void) 
}



static int map_lapic_id(struct acpi_subtable_header *entry,

		 u32 acpi_id, phys_cpuid_t *apic_id, bool ignore_disabled)

		 u32 acpi_id, phys_cpuid_t *apic_id)

{

	struct acpi_madt_local_apic *lapic =

		container_of(entry, struct acpi_madt_local_apic, header);



	if (ignore_disabled && !(lapic->lapic_flags & ACPI_MADT_ENABLED))

	if (!(lapic->lapic_flags & ACPI_MADT_ENABLED))

		return -ENODEV;



	if (lapic->processor_id != acpi_id)
@@ -48,13 +48,12 @@ static int map_lapic_id(struct acpi_subtable_header *entry, 
}



static int map_x2apic_id(struct acpi_subtable_header *entry,

		int device_declaration, u32 acpi_id, phys_cpuid_t *apic_id,

		bool ignore_disabled)

		int device_declaration, u32 acpi_id, phys_cpuid_t *apic_id)

{

	struct acpi_madt_local_x2apic *apic =

		container_of(entry, struct acpi_madt_local_x2apic, header);



	if (ignore_disabled && !(apic->lapic_flags & ACPI_MADT_ENABLED))

	if (!(apic->lapic_flags & ACPI_MADT_ENABLED))

		return -ENODEV;



	if (device_declaration && (apic->uid == acpi_id)) {
@@ -66,13 +65,12 @@ static int map_x2apic_id(struct acpi_subtable_header *entry, 
}



static int map_lsapic_id(struct acpi_subtable_header *entry,

		int device_declaration, u32 acpi_id, phys_cpuid_t *apic_id,

		bool ignore_disabled)

		int device_declaration, u32 acpi_id, phys_cpuid_t *apic_id)

{

	struct acpi_madt_local_sapic *lsapic =

		container_of(entry, struct acpi_madt_local_sapic, header);



	if (ignore_disabled && !(lsapic->lapic_flags & ACPI_MADT_ENABLED))

	if (!(lsapic->lapic_flags & ACPI_MADT_ENABLED))

		return -ENODEV;



	if (device_declaration) {
@@ -89,13 +87,12 @@ static int map_lsapic_id(struct acpi_subtable_header *entry, 
 * Retrieve the ARM CPU physical identifier (MPIDR)

 */

static int map_gicc_mpidr(struct acpi_subtable_header *entry,

		int device_declaration, u32 acpi_id, phys_cpuid_t *mpidr,

		bool ignore_disabled)

		int device_declaration, u32 acpi_id, phys_cpuid_t *mpidr)

{

	struct acpi_madt_generic_interrupt *gicc =

	    container_of(entry, struct acpi_madt_generic_interrupt, header);



	if (ignore_disabled && !(gicc->flags & ACPI_MADT_ENABLED))

	if (!(gicc->flags & ACPI_MADT_ENABLED))

		return -ENODEV;



	/* device_declaration means Device object in DSDT, in the
@@ -112,7 +109,7 @@ static int map_gicc_mpidr(struct acpi_subtable_header *entry, 
}



static phys_cpuid_t map_madt_entry(struct acpi_table_madt *madt,

				   int type, u32 acpi_id, bool ignore_disabled)

				   int type, u32 acpi_id)

{

	unsigned long madt_end, entry;

	phys_cpuid_t phys_id = PHYS_CPUID_INVALID;	/* CPU hardware ID */
@@ -130,20 +127,16 @@ static phys_cpuid_t map_madt_entry(struct acpi_table_madt *madt, 
		struct acpi_subtable_header *header =

			(struct acpi_subtable_header *)entry;

		if (header->type == ACPI_MADT_TYPE_LOCAL_APIC) {

			if (!map_lapic_id(header, acpi_id, &phys_id,

					  ignore_disabled))

			if (!map_lapic_id(header, acpi_id, &phys_id))

				break;

		} else if (header->type == ACPI_MADT_TYPE_LOCAL_X2APIC) {

			if (!map_x2apic_id(header, type, acpi_id, &phys_id,

					   ignore_disabled))

			if (!map_x2apic_id(header, type, acpi_id, &phys_id))

				break;

		} else if (header->type == ACPI_MADT_TYPE_LOCAL_SAPIC) {

			if (!map_lsapic_id(header, type, acpi_id, &phys_id,

					   ignore_disabled))

			if (!map_lsapic_id(header, type, acpi_id, &phys_id))

				break;

		} else if (header->type == ACPI_MADT_TYPE_GENERIC_INTERRUPT) {

			if (!map_gicc_mpidr(header, type, acpi_id, &phys_id,

					    ignore_disabled))

			if (!map_gicc_mpidr(header, type, acpi_id, &phys_id))

				break;

		}

		entry += header->length;
@@ -161,15 +154,14 @@ phys_cpuid_t __init acpi_map_madt_entry(u32 acpi_id) 
	if (!madt)

		return PHYS_CPUID_INVALID;



	rv = map_madt_entry(madt, 1, acpi_id, true);

	rv = map_madt_entry(madt, 1, acpi_id);



	acpi_put_table((struct acpi_table_header *)madt);



	return rv;

}



static phys_cpuid_t map_mat_entry(acpi_handle handle, int type, u32 acpi_id,

				  bool ignore_disabled)

static phys_cpuid_t map_mat_entry(acpi_handle handle, int type, u32 acpi_id)

{

	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };

	union acpi_object *obj;
@@ -190,38 +182,30 @@ static phys_cpuid_t map_mat_entry(acpi_handle handle, int type, u32 acpi_id, 


	header = (struct acpi_subtable_header *)obj->buffer.pointer;

	if (header->type == ACPI_MADT_TYPE_LOCAL_APIC)

		map_lapic_id(header, acpi_id, &phys_id, ignore_disabled);

		map_lapic_id(header, acpi_id, &phys_id);

	else if (header->type == ACPI_MADT_TYPE_LOCAL_SAPIC)

		map_lsapic_id(header, type, acpi_id, &phys_id, ignore_disabled);

		map_lsapic_id(header, type, acpi_id, &phys_id);

	else if (header->type == ACPI_MADT_TYPE_LOCAL_X2APIC)

		map_x2apic_id(header, type, acpi_id, &phys_id, ignore_disabled);

		map_x2apic_id(header, type, acpi_id, &phys_id);

	else if (header->type == ACPI_MADT_TYPE_GENERIC_INTERRUPT)

		map_gicc_mpidr(header, type, acpi_id, &phys_id,

			       ignore_disabled);

		map_gicc_mpidr(header, type, acpi_id, &phys_id);



exit:

	kfree(buffer.pointer);

	return phys_id;

}



static phys_cpuid_t __acpi_get_phys_id(acpi_handle handle, int type,

				       u32 acpi_id, bool ignore_disabled)

phys_cpuid_t acpi_get_phys_id(acpi_handle handle, int type, u32 acpi_id)

{

	phys_cpuid_t phys_id;



	phys_id = map_mat_entry(handle, type, acpi_id, ignore_disabled);

	phys_id = map_mat_entry(handle, type, acpi_id);

	if (invalid_phys_cpuid(phys_id))

		phys_id = map_madt_entry(get_madt_table(), type, acpi_id,

					   ignore_disabled);

		phys_id = map_madt_entry(get_madt_table(), type, acpi_id);



	return phys_id;

}



phys_cpuid_t acpi_get_phys_id(acpi_handle handle, int type, u32 acpi_id)

{

	return __acpi_get_phys_id(handle, type, acpi_id, true);

}



int acpi_map_cpuid(phys_cpuid_t phys_id, u32 acpi_id)

{

#ifdef CONFIG_SMP
@@ -278,79 +262,6 @@ int acpi_get_cpuid(acpi_handle handle, int type, u32 acpi_id) 
}

EXPORT_SYMBOL_GPL(acpi_get_cpuid);



#ifdef CONFIG_ACPI_HOTPLUG_CPU

static bool __init

map_processor(acpi_handle handle, phys_cpuid_t *phys_id, int *cpuid)

{

	int type, id;

	u32 acpi_id;

	acpi_status status;

	acpi_object_type acpi_type;

	unsigned long long tmp;

	union acpi_object object = { 0 };

	struct acpi_buffer buffer = { sizeof(union acpi_object), &object };



	status = acpi_get_type(handle, &acpi_type);

	if (ACPI_FAILURE(status))

		return false;



	switch (acpi_type) {

	case ACPI_TYPE_PROCESSOR:

		status = acpi_evaluate_object(handle, NULL, NULL, &buffer);

		if (ACPI_FAILURE(status))

			return false;

		acpi_id = object.processor.proc_id;



		/* validate the acpi_id */

		if(acpi_processor_validate_proc_id(acpi_id))

			return false;

		break;

	case ACPI_TYPE_DEVICE:

		status = acpi_evaluate_integer(handle, "_UID", NULL, &tmp);

		if (ACPI_FAILURE(status))

			return false;

		acpi_id = tmp;

		break;

	default:

		return false;

	}



	type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0;



	*phys_id = __acpi_get_phys_id(handle, type, acpi_id, false);

	id = acpi_map_cpuid(*phys_id, acpi_id);



	if (id < 0)

		return false;

	*cpuid = id;

	return true;

}



static acpi_status __init

set_processor_node_mapping(acpi_handle handle, u32 lvl, void *context,

			   void **rv)

{

	phys_cpuid_t phys_id;

	int cpu_id;



	if (!map_processor(handle, &phys_id, &cpu_id))

		return AE_ERROR;



	acpi_map_cpu2node(handle, cpu_id, phys_id);

	return AE_OK;

}



void __init acpi_set_processor_mapping(void)

{

	/* Set persistent cpu <-> node mapping for all processors. */

	acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,

			    ACPI_UINT32_MAX, set_processor_node_mapping,

			    NULL, NULL, NULL);

}

#else

void __init acpi_set_processor_mapping(void) {}

#endif /* CONFIG_ACPI_HOTPLUG_CPU */



#ifdef CONFIG_ACPI_HOTPLUG_IOAPIC

static int get_ioapic_id(struct acpi_subtable_header *entry, u32 gsi_base,

			 u64 *phys_addr, int *ioapic_id)

CRA Git | Maintained and supported by SUSTech CRA and CCSE