Commit ae128293 authored Jun 15, 2015 by Krzysztof Kozlowski Committed by Vinod Koul Jul 07, 2015

dmaengine: pl330: Fix overflow when reporting residue in memcpy



During memcpy operations the residue was always set to an u32 overflowed
value.

In pl330_tx_status() function number of currently transferred bytes was
subtracted from internal "bytes_requested" field. However this
"bytes_requested" was not initialized at start to length of memcpy
buffer so transferred bytes were subtracted from 0 causing overflow.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: <stable@vger.kernel.org>
Fixes: aee4d1fa ("dmaengine: pl330: improve pl330_tx_status() function")
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent d770e558

drivers/dma/pl330.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2623,6 +2623,7 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
		desc->rqcfg.brst_len = 1;

		desc->rqcfg.brst_len = get_burst_len(desc, len);
		desc->bytes_requested = len;

		desc->txd.flags = flags;

Admin message