[SCSI] add flag to skip the runtime PM calls on the host (ae0751ff) · Commits · 戴 / test

With previous change, now the ata port runtime suspend will happen as: disk suspend --> scsi target suspend --> scsi host suspend --> ata port suspend ata port(parent device) suspend need to schedule scsi EH which will resume scsi host(child device). Then the child device resume will in turn make parent device resume first. This is kind of recursive. This patch adds a new flag Scsi_Host::eh_noresume. ata port will set this flag to skip the runtime PM calls on scsi host. Acked-by:

Alan Stern <stern@rowland.harvard.edu> Signed-off-by:

Lin Ming <ming.m.lin@intel.com> Signed-off-by:

Jeff Garzik <jgarzik@redhat.com>

drivers/scsi/scsi_error.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1812,7 +1812,7 @@ int scsi_error_handler(void *data)
		* what we need to do to get it up and online again (if we can).
		* If we fail, we end up taking the thing offline.
		*/
		if (scsi_autopm_get_host(shost) != 0) {
		if (!shost->eh_noresume && scsi_autopm_get_host(shost) != 0) {
		SCSI_LOG_ERROR_RECOVERY(1,
		printk(KERN_ERR "Error handler scsi_eh_%d "
		"unable to autoresume\n",
		@@ -1833,6 +1833,7 @@ int scsi_error_handler(void *data)
		* which are still online.
		*/
		scsi_restart_operations(shost);
		if (!shost->eh_noresume)
		scsi_autopm_put_host(shost);
		set_current_state(TASK_INTERRUPTIBLE);
		}

include/scsi/scsi_host.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -669,6 +669,9 @@ struct Scsi_Host {
		/* Asynchronous scan in progress */
		unsigned async_scan:1;

		/* Don't resume host in EH */
		unsigned eh_noresume:1;

		/*
		* Optional work queue to be utilized by the transport
		*/

Admin message