Commit adfae8a5 authored Mar 10, 2017 by bob picco Committed by David S. Miller Mar 27, 2017

sparc64: kern_addr_valid regression



I encountered this bug when using /proc/kcore to examine the kernel. Plus a
coworker inquired about debugging tools. We computed pa but did
not use it during the maximum physical address bits test. Instead we used
the identity mapped virtual address which will always fail this test.

I believe the defect came in here:
[bpicco@zareason linus.git]$ git describe --contains bb4e6e85
v3.18-rc1~87^2~4
.

Signed-off-by: Bob Picco <bob.picco@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 85b1da7c

arch/sparc/mm/init_64.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1567,7 +1567,7 @@ bool kern_addr_valid(unsigned long addr)
		if ((long)addr < 0L) {
		unsigned long pa = __pa(addr);

		if ((addr >> max_phys_bits) != 0UL)
		if ((pa >> max_phys_bits) != 0UL)
		return false;

		return pfn_valid(pa >> PAGE_SHIFT);

Admin message