Commit adf5091e authored by Frederic Weisbecker's avatar Frederic Weisbecker
Browse files

rcu: New rcu_user_enter() and rcu_user_exit() APIs 



RCU currently insists that only idle tasks can enter RCU idle mode, which
prohibits an adaptive tickless kernel (AKA nohz cpusets), which in turn
would mean that usermode execution would always take scheduling-clock
interrupts, even when there is only one task runnable on the CPU in
question.

This commit therefore adds rcu_user_enter() and rcu_user_exit(), which
allow non-idle tasks to enter RCU idle mode.  These are quite similar
to rcu_idle_enter() and rcu_idle_exit(), respectively, except that they
omit the idle-task checks.

[ Updated to use "user" flag rather than separate check functions. ]

[ paulmck: Updated to drop exports of new functions based on Josh's patch
  getting rid of the need for them. ]

Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Alessio Igor Bogani <abogani@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Avi Kivity <avi@redhat.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Geoff Levand <geoff@infradead.org>
Cc: Gilad Ben Yossef <gilad@benyossef.com>
Cc: Hakan Akkan <hakanakkan@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Kevin Hilman <khilman@ti.com>
Cc: Max Krasnyansky <maxk@qualcomm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Sven-Thorsten Dietrich <thebigcorporation@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
parent 593d1006

include/linux/rcupdate.h

+2 −0
Original line number Diff line number Diff line
@@ -191,6 +191,8 @@ extern void rcu_idle_enter(void); 
extern void rcu_idle_exit(void);

extern void rcu_irq_enter(void);

extern void rcu_irq_exit(void);

extern void rcu_user_enter(void);

extern void rcu_user_exit(void);

extern void exit_rcu(void);



/**

kernel/rcutree.c

+101 −34
Original line number Diff line number Diff line
@@ -322,16 +322,17 @@ static struct rcu_node *rcu_get_root(struct rcu_state *rsp) 
}



/*

 * rcu_idle_enter_common - inform RCU that current CPU is moving towards idle

 * rcu_eqs_enter_common - current CPU is moving towards extended quiescent state

 *

 * If the new value of the ->dynticks_nesting counter now is zero,

 * we really have entered idle, and must do the appropriate accounting.

 * The caller must have disabled interrupts.

 */

static void rcu_idle_enter_common(struct rcu_dynticks *rdtp, long long oldval)

static void rcu_eqs_enter_common(struct rcu_dynticks *rdtp, long long oldval,

				bool user)

{

	trace_rcu_dyntick("Start", oldval, 0);

	if (!is_idle_task(current)) {

	if (!is_idle_task(current) && !user) {

		struct task_struct *idle = idle_task(smp_processor_id());



		trace_rcu_dyntick("Error on entry: not idle task", oldval, 0);
@@ -348,7 +349,7 @@ static void rcu_idle_enter_common(struct rcu_dynticks *rdtp, long long oldval) 
	WARN_ON_ONCE(atomic_read(&rdtp->dynticks) & 0x1);



	/*

	 * The idle task is not permitted to enter the idle loop while

	 * It is illegal to enter an extended quiescent state while

	 * in an RCU read-side critical section.

	 */

	rcu_lockdep_assert(!lock_is_held(&rcu_lock_map),
@@ -359,19 +360,11 @@ static void rcu_idle_enter_common(struct rcu_dynticks *rdtp, long long oldval) 
			   "Illegal idle entry in RCU-sched read-side critical section.");

}



/**

 * rcu_idle_enter - inform RCU that current CPU is entering idle

 *

 * Enter idle mode, in other words, -leave- the mode in which RCU

 * read-side critical sections can occur.  (Though RCU read-side

 * critical sections can occur in irq handlers in idle, a possibility

 * handled by irq_enter() and irq_exit().)

 *

 * We crowbar the ->dynticks_nesting field to zero to allow for

 * the possibility of usermode upcalls having messed up our count

 * of interrupt nesting level during the prior busy period.

/*

 * Enter an RCU extended quiescent state, which can be either the

 * idle loop or adaptive-tickless usermode execution.

 */

void rcu_idle_enter(void)

static void rcu_eqs_enter(bool user)

{

	unsigned long flags;

	long long oldval;
@@ -385,11 +378,53 @@ void rcu_idle_enter(void) 
		rdtp->dynticks_nesting = 0;

	else

		rdtp->dynticks_nesting -= DYNTICK_TASK_NEST_VALUE;

	rcu_idle_enter_common(rdtp, oldval);

	rcu_eqs_enter_common(rdtp, oldval, user);

	local_irq_restore(flags);

}



/**

 * rcu_idle_enter - inform RCU that current CPU is entering idle

 *

 * Enter idle mode, in other words, -leave- the mode in which RCU

 * read-side critical sections can occur.  (Though RCU read-side

 * critical sections can occur in irq handlers in idle, a possibility

 * handled by irq_enter() and irq_exit().)

 *

 * We crowbar the ->dynticks_nesting field to zero to allow for

 * the possibility of usermode upcalls having messed up our count

 * of interrupt nesting level during the prior busy period.

 */

void rcu_idle_enter(void)

{

	rcu_eqs_enter(0);

}

EXPORT_SYMBOL_GPL(rcu_idle_enter);



/**

 * rcu_user_enter - inform RCU that we are resuming userspace.

 *

 * Enter RCU idle mode right before resuming userspace.  No use of RCU

 * is permitted between this call and rcu_user_exit(). This way the

 * CPU doesn't need to maintain the tick for RCU maintenance purposes

 * when the CPU runs in userspace.

 */

void rcu_user_enter(void)

{

	/*

	 * Some contexts may involve an exception occuring in an irq,

	 * leading to that nesting:

	 * rcu_irq_enter() rcu_user_exit() rcu_user_exit() rcu_irq_exit()

	 * This would mess up the dyntick_nesting count though. And rcu_irq_*()

	 * helpers are enough to protect RCU uses inside the exception. So

	 * just return immediately if we detect we are in an IRQ.

	 */

	if (in_interrupt())

		return;



	rcu_eqs_enter(1);

}





/**

 * rcu_irq_exit - inform RCU that current CPU is exiting irq towards idle

 *
@@ -420,18 +455,19 @@ void rcu_irq_exit(void) 
	if (rdtp->dynticks_nesting)

		trace_rcu_dyntick("--=", oldval, rdtp->dynticks_nesting);

	else

		rcu_idle_enter_common(rdtp, oldval);

		rcu_eqs_enter_common(rdtp, oldval, 1);

	local_irq_restore(flags);

}



/*

 * rcu_idle_exit_common - inform RCU that current CPU is moving away from idle

 * rcu_eqs_exit_common - current CPU moving away from extended quiescent state

 *

 * If the new value of the ->dynticks_nesting counter was previously zero,

 * we really have exited idle, and must do the appropriate accounting.

 * The caller must have disabled interrupts.

 */

static void rcu_idle_exit_common(struct rcu_dynticks *rdtp, long long oldval)

static void rcu_eqs_exit_common(struct rcu_dynticks *rdtp, long long oldval,

			       int user)

{

	smp_mb__before_atomic_inc();  /* Force ordering w/previous sojourn. */

	atomic_inc(&rdtp->dynticks);
@@ -440,7 +476,7 @@ static void rcu_idle_exit_common(struct rcu_dynticks *rdtp, long long oldval) 
	WARN_ON_ONCE(!(atomic_read(&rdtp->dynticks) & 0x1));

	rcu_cleanup_after_idle(smp_processor_id());

	trace_rcu_dyntick("End", oldval, rdtp->dynticks_nesting);

	if (!is_idle_task(current)) {

	if (!is_idle_task(current) && !user) {

		struct task_struct *idle = idle_task(smp_processor_id());



		trace_rcu_dyntick("Error on exit: not idle task",
@@ -452,18 +488,11 @@ static void rcu_idle_exit_common(struct rcu_dynticks *rdtp, long long oldval) 
	}

}



/**

 * rcu_idle_exit - inform RCU that current CPU is leaving idle

 *

 * Exit idle mode, in other words, -enter- the mode in which RCU

 * read-side critical sections can occur.

 *

 * We crowbar the ->dynticks_nesting field to DYNTICK_TASK_NEST to

 * allow for the possibility of usermode upcalls messing up our count

 * of interrupt nesting level during the busy period that is just

 * now starting.

/*

 * Exit an RCU extended quiescent state, which can be either the

 * idle loop or adaptive-tickless usermode execution.

 */

void rcu_idle_exit(void)

static void rcu_eqs_exit(bool user)

{

	unsigned long flags;

	struct rcu_dynticks *rdtp;
@@ -477,11 +506,49 @@ void rcu_idle_exit(void) 
		rdtp->dynticks_nesting += DYNTICK_TASK_NEST_VALUE;

	else

		rdtp->dynticks_nesting = DYNTICK_TASK_EXIT_IDLE;

	rcu_idle_exit_common(rdtp, oldval);

	rcu_eqs_exit_common(rdtp, oldval, user);

	local_irq_restore(flags);

}



/**

 * rcu_idle_exit - inform RCU that current CPU is leaving idle

 *

 * Exit idle mode, in other words, -enter- the mode in which RCU

 * read-side critical sections can occur.

 *

 * We crowbar the ->dynticks_nesting field to DYNTICK_TASK_NEST to

 * allow for the possibility of usermode upcalls messing up our count

 * of interrupt nesting level during the busy period that is just

 * now starting.

 */

void rcu_idle_exit(void)

{

	rcu_eqs_exit(0);

}

EXPORT_SYMBOL_GPL(rcu_idle_exit);



/**

 * rcu_user_exit - inform RCU that we are exiting userspace.

 *

 * Exit RCU idle mode while entering the kernel because it can

 * run a RCU read side critical section anytime.

 */

void rcu_user_exit(void)

{

	/*

	 * Some contexts may involve an exception occuring in an irq,

	 * leading to that nesting:

	 * rcu_irq_enter() rcu_user_exit() rcu_user_exit() rcu_irq_exit()

	 * This would mess up the dyntick_nesting count though. And rcu_irq_*()

	 * helpers are enough to protect RCU uses inside the exception. So

	 * just return immediately if we detect we are in an IRQ.

	 */

	if (in_interrupt())

		return;



	rcu_eqs_exit(1);

}



/**

 * rcu_irq_enter - inform RCU that current CPU is entering irq away from idle

 *
@@ -515,7 +582,7 @@ void rcu_irq_enter(void) 
	if (oldval)

		trace_rcu_dyntick("++=", oldval, rdtp->dynticks_nesting);

	else

		rcu_idle_exit_common(rdtp, oldval);

		rcu_eqs_exit_common(rdtp, oldval, 1);

	local_irq_restore(flags);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE