Commit add64526 authored May 20, 2014 by Peter Senna Tschudin Committed by Greg Kroah-Hartman May 24, 2014

staging: ft1000: Remove useless return variables



This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent bf526957

drivers/staging/ft1000/ft1000-usb/ft1000_download.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -522,7 +522,6 @@ static void usb_dnld_complete(struct urb *urb)
		static int write_blk_fifo(struct ft1000_usb ft1000dev, u16 *pUsFile,
		u8 **pUcFile, long word_length)
		{
		int Status = 0;
		int byte_length;

		byte_length = word_length * 4;
		@@ -547,7 +546,7 @@ static int write_blk_fifo(struct ft1000_usb ft1000dev, u16 *pUsFile,
		pUsFile = pUsFile + (word_length << 1);
		pUcFile = pUcFile + (word_length << 2);

		return Status;
		return 0;
		}

		static int scram_start_dwnld(struct ft1000_usb ft1000dev, u16 hshake,

Admin message