Commit add3d95d authored by Tom St Denis's avatar Tom St Denis Committed by Alex Deucher
Browse files

drm/ttm: Simplify ttm_dma_find_pool() (v2) 



Flip the logic of the comparison and remove
the redudant variable for the pool address.

(v2): Remove {} bracing.

Signed-off-by: default avatarTom St Denis <tom.stdenis@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c68edaa0

drivers/gpu/drm/ttm/ttm_page_alloc_dma.c

+6 −9
Original line number Diff line number Diff line
@@ -682,10 +682,10 @@ err_mem: 
static struct dma_pool *ttm_dma_find_pool(struct device *dev,

					  enum pool_type type)

{

	struct dma_pool *pool, *tmp, *found = NULL;

	struct dma_pool *pool, *tmp;



	if (type == IS_UNDEFINED)

		return found;

		return NULL;



	/* NB: We iterate on the 'struct dev' which has no spinlock, but

	 * it does have a kref which we have taken. The kref is taken during
@@ -698,13 +698,10 @@ static struct dma_pool *ttm_dma_find_pool(struct device *dev, 
	 * thing is at that point of time there are no pages associated with the

	 * driver so this function will not be called.

	 */

	list_for_each_entry_safe(pool, tmp, &dev->dma_pools, pools) {

		if (pool->type != type)

			continue;

		found = pool;

		break;

	}

	return found;

	list_for_each_entry_safe(pool, tmp, &dev->dma_pools, pools)

		if (pool->type == type)

			return pool;

	return NULL;

}



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE