Commit adbc3ddf authored Oct 11, 2017 by Bob Peterson Committed by Andreas Gruenbacher Oct 31, 2017

GFS2: flush the log and all pages for jdata as we do for WB_SYNC_ALL



In function gfs2_write_inode, starting with patch a9185b41, we
only flush the log and call filemap_fdatawait if we're passed in a
wbc sync_mode of WB_SYNC_ALL. We also need to do these things if
we're evicting a jdata inode, because we might have jdata pages
still attached to bufdata descriptors that need to be revoked, but
by the time it gets to evict() it's too late to start a new
transaction. This patch changes it to treat jdata inodes as if
WB_SYNC_ALL had been specified.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Acked-by: Abhijith Das <adas@redhat.com>

parent 3a27411c

fs/gfs2/super.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -754,14 +754,15 @@ static int gfs2_write_inode(struct inode inode, struct writeback_control wbc)
		struct address_space *metamapping = gfs2_glock2aspace(ip->i_gl);
		struct backing_dev_info *bdi = inode_to_bdi(metamapping->host);
		int ret = 0;
		bool flush_all = (wbc->sync_mode == WB_SYNC_ALL \|\| gfs2_is_jdata(ip));

		if (wbc->sync_mode == WB_SYNC_ALL)
		if (flush_all)
		gfs2_log_flush(GFS2_SB(inode), ip->i_gl, NORMAL_FLUSH);
		if (bdi->wb.dirty_exceeded)
		gfs2_ail1_flush(sdp, wbc);
		else
		filemap_fdatawrite(metamapping);
		if (wbc->sync_mode == WB_SYNC_ALL)
		if (flush_all)
		ret = filemap_fdatawait(metamapping);
		if (ret)
		mark_inode_dirty_sync(inode);

Admin message