Commit adb09184 authored Aug 24, 2011 by Anton Blanchard Committed by Arnaldo Carvalho de Melo Sep 23, 2011

perf symbols: Fix ppc64 SEGV in dso__load_sym with debuginfo files

64bit PowerPC debuginfo files have an empty function descriptor section.
I hit a SEGV when perf tried to use this section for symbol resolution.

To fix this we need to check the section is valid and we can do this by
checking for type SHT_PROGBITS.

Cc: <stable@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Eric B Munson <emunson@mgebm.net>
Link: http://lkml.kernel.org/r/20110824065242.895239970@samba.org

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent f66fedcb

tools/perf/util/symbol.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1111,6 +1111,8 @@ static int dso__load_sym(struct dso dso, struct map map, const char *name,
	}		}

	opdsec = elf_section_by_name(elf, &ehdr, &opdshdr, ".opd", &opdidx);		opdsec = elf_section_by_name(elf, &ehdr, &opdshdr, ".opd", &opdidx);
			if (opdshdr.sh_type != SHT_PROGBITS)
			opdsec = NULL;
	if (opdsec)		if (opdsec)
	opddata = elf_rawdata(opdsec, NULL);		opddata = elf_rawdata(opdsec, NULL);

Admin message