Commit adaa4b8e authored Mar 21, 2013 by Jan Schmidt Committed by Josef Bacik Mar 28, 2013

Btrfs: fix EIO from btrfs send in is_extent_unchanged for punched holes



When you take a snapshot, punch a hole where there has been data, then take
another snapshot and try to send an incremental stream, btrfs send would
give you EIO. That is because is_extent_unchanged had no support for holes
being punched. With this patch, instead of returning EIO we just return
0 (== the extent is not unchanged) and we're good.

Signed-off-by: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: Alexander Block <ablock84@gmail.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>

parent 4adaa611

fs/btrfs/send.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -3945,13 +3945,11 @@ static int is_extent_unchanged(struct send_ctx *sctx,
		found_key.type != key.type) {
		key.offset += right_len;
		break;
		} else {
		}
		if (found_key.offset != key.offset + right_len) {
		/* Should really not happen */
		ret = -EIO;
		ret = 0;
		goto out;
		}
		}
		key = found_key;
		}

Admin message